Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mechanism for change kernel name via kw #189

Open
rodrigosiqueira opened this issue Jul 6, 2020 · 0 comments
Open

Add a mechanism for change kernel name via kw #189

rodrigosiqueira opened this issue Jul 6, 2020 · 0 comments
Labels
deploy good first issue Good for newcomers New feature request
Projects
Deploy

Comments

@rodrigosiqueira
Copy link
Collaborator

A kw user requested a mechanism for adding a kernel name. It could be nice if we can handle a kernel name via kw, for example, in the kworkflow.config:

kernel_name=AN-COOL-NAME

we could also support it via command line:

kw deploy --name AN-COOL-NAME
@rodrigosiqueira rodrigosiqueira added this to TODO in Deploy Jan 15, 2022
hilookas added a commit to hilookas/kworkflow that referenced this issue Sep 17, 2022
@hilookas
src: build: Add renaming feature in build.sh and unify naming of
907f987 
`kernel_name` in `deploy.sh`

After this commit, user can easily change kernel name simply adding
a param after build command. Comparing to naming in deploy, naming in
build process will keep consistency in grub uname etc.

Closes: kworkflow#189

Some legacy variables like `mkinitcpio_name` is never used and the
kernel name is called in different ways in many place such as `name`,
`kernel_name` and both `name` and `kernel_name` which is confusing.

This commit unify naming of them.

Signed-off-by: Haiqin Cui <i@18kas.com>
hilookas added a commit to hilookas/kworkflow that referenced this issue Sep 17, 2022
@hilookas
src: build: Add renaming feature in build.sh and unify naming of `k…
5ed4957 
…ernel_name` in `deploy.sh`

After this commit, user can easily change kernel name simply adding
a param after build command. Comparing to naming in deploy, naming in
build process will keep consistency in grub uname etc.

Closes: kworkflow#189

Some legacy variables like `mkinitcpio_name` is never used and the
kernel name is called in different ways in many place such as `name`,
`kernel_name` and both `name` and `kernel_name` which is confusing.

This commit unify naming of them.

Signed-off-by: Haiqin Cui <i@18kas.com>
@hilookas hilookas mentioned this issue Sep 17, 2022
Closed
hilookas added a commit to hilookas/kworkflow that referenced this issue Sep 25, 2022
@hilookas
src: build: Add renaming feature in build.sh and unify naming of `k…
2a3ae2b 
…ernel_name` in `deploy.sh`

After this commit, user can easily change kernel name simply adding
a param after build command. Comparing to naming in deploy, naming in
build process will keep consistency in grub uname etc.

Closes: kworkflow#189

Some legacy variables like `mkinitcpio_name` is never used and the
kernel name is called in different ways in many place such as `name`,
`kernel_name` and both `name` and `kernel_name` which is confusing.

This commit unify naming of them.

Signed-off-by: Haiqin Cui <i@18kas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deploy good first issue Good for newcomers New feature request
Projects
No open projects
Deploy
TODO
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rodrigosiqueira