Small build fixes - #615
Closed
antisaling wants to merge 3 commits into
Closed
Conversation
antisaling
force-pushed
the
small-build-fixes
branch
from
May 26, 2022 23:06
ef88a72 to
7d50c54
Compare
Codecov Report
@@ Coverage Diff @@
## unstable #615 +/- ##
============================================
- Coverage 73.76% 73.74% -0.02%
============================================
Files 36 36
Lines 5553 5558 +5
============================================
+ Hits 4096 4099 +3
- Misses 1457 1459 +2
Continue to review full report at Codecov.
|
antisaling
force-pushed
the
small-build-fixes
branch
2 times, most recently
from
May 26, 2022 23:20
939f11c to
0b88130
Compare
Collaborator
|
@isinyaaa |
When used without a number, the `-j` flag will create as many threads as needed. This works pretty well for small tasks such as when using one of the various "menu"config utilities or when preparing an environment for a new compilation. Signed-off-by: Isabella Basso <isabbasso@riseup.net>
As per [1], the `kw_parse` wrapper should be used instead of the `getopt` command for command line options parsing in kw. This commit also improves readability of flags passed in the build test. [1] - src: kwlib: Create command line parser for kw (48db7ec) Signed-off-by: Isabella Basso <isabbasso@riseup.net>
This fixes whitespace incoherences that happen when some options are not used when building the kernel. Signed-off-by: Isabella Basso <isabbasso@riseup.net>
antisaling
force-pushed
the
small-build-fixes
branch
from
May 27, 2022 18:32
0b88130 to
d4ec86a
Compare
Collaborator
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those are small fixes to the
src/build.shfile I made during PR's #543 development. Note: it's based on #614.