Repository navigation
Separate build config from base kw config - #616
antisaling wants to merge 3 commits into
Conversation
|
Hi @isinyaaa , |
dedc45b to
af85953
Compare
|
@isinyaaa could you check the unit test failure? |
af85953 to
687d6b8
Compare
|
It seems that the |
687d6b8 to
a6e2ec8
Compare
This function has been superseded by the one in `kw init`, making it always fail kw's set up tests in the CI needlessly. Signed-off-by: Isabella Basso <isabbasso@riseup.net>
This should provide a small performance improvement as we're no longer processing empty lines in the parser. Signed-off-by: Isabella Basso <isabbasso@riseup.net>
a6e2ec8 to
e56d8cc
Compare
Codecov Report
@@ Coverage Diff @@
## unstable #616 +/- ##
============================================
- Coverage 73.84% 73.74% -0.10%
============================================
Files 36 36
Lines 5574 5645 +71
============================================
+ Hits 4116 4163 +47
- Misses 1458 1482 +24
Continue to review full report at Codecov.
|
e56d8cc to
a69ca16
Compare
This adds a separate config file for build options, so that they can be separated as needed, i.e. per-environment (see kworkflow#537). Signed-off-by: Isabella Basso <isabbasso@riseup.net>
a69ca16 to
d538327
Compare
|
Hi @isinyaaa , I did not complete my review yet, but I noticed some bugs. If you try:
you will see an error like this: If you try: You will see something like this: Could you take a look at that? |
|
I fixed the issue that I mentioned before and merged this change in the unstable branch. Thanks. |
This is a change requested by @rodrigosiqueira in PR #543 that was quite large, so I preferred to split it. Note: this is based on #615.