Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reddit forum link to the home page #48

Closed
wants to merge 4 commits into from

Conversation

@lucasprag
Copy link
Member

lucasprag commented Dec 30, 2019

Move social links to footer and aligh navbar links to the right

This is needed so we can have more links in the navbar such as the code
of conduct (to be added) and others.

Also, I change the container in the navbar to not be fluid.

Before:

Screen Shot 2019-12-30 at 8 24 51 AM

After:

Screen Shot 2019-12-30 at 8 51 12 AM

Thanks =)

lucasprag added 2 commits Dec 30, 2019
This is needed so we can have more links in the navbar such as the code
of conduct (to be added) and others.
Also, refactor the home page to use SVGs for reddit and meetup
@lucasprag

This comment has been minimized.

Copy link
Member Author

lucasprag commented Dec 30, 2019

Since this PR was open I added one more commit which:

  • add a link to our sub reddit and its chat room
  • add SVGs for the reddit and meetup logos

Some screenshots in different screen sizes:

Screen Shot 2019-12-30 at 12 35 56 PM

Screen Shot 2019-12-30 at 12 36 07 PM

Screen Shot 2019-12-30 at 12 36 20 PM

Screen Shot 2019-12-30 at 12 36 30 PM

@lucasprag lucasprag changed the title Move social links to footer and aligh navbar links to the right Add reddit forum and chat links to the home page Dec 30, 2019
@lucasprag

This comment has been minimized.

Copy link
Member Author

lucasprag commented Jan 6, 2020

I updated it to not say anything about a chat just yet since we are going to do Matrix (see #1 (comment)).

Screen Shot 2020-01-05 at 9 36 13 PM

@acant

This comment has been minimized.

Copy link
Contributor

acant commented Jan 9, 2020

@lucasprag thank you for all the great PRs! I really appreciate that you have been creating the screenshots, because it makes it really easy to review what the change will do.

After merging in the code of conduct from #47, this PR needs resolution. :) Can you resolve it? I can do it on the weekend, if you do not have an opportunity.

I will get the matrix stuff setup and then we can, figure out the best way to link it, too!

Thanks again for your work @lucasprag it is much appreciated!

@lucasprag

This comment has been minimized.

Copy link
Member Author

lucasprag commented Jan 9, 2020

Awesome, thank you, I really appreciate your work maintaining this community @acant =)
The conflict is gone 🎉

Firefox:
Screen Shot 2020-01-09 at 9 21 02 AM

Google Chrome:
Screen Shot 2020-01-09 at 9 21 13 AM

@lucasprag lucasprag changed the title Add reddit forum and chat links to the home page Add reddit forum link to the home page Jan 13, 2020
@acant

This comment has been minimized.

Copy link
Contributor

acant commented Jan 13, 2020

I am not sure why the rebase could not be done in the UI, but I followed the CLI instructions and did the rebase and merge manually. The site has been automatically re-built, and the changes are being displayed!

@acant acant closed this Jan 13, 2020
@lucasprag

This comment has been minimized.

Copy link
Member Author

lucasprag commented Jan 14, 2020

Awesome, thanks =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.