New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstanard1.3 and net46 #1271

Merged
merged 1 commit into from Jun 24, 2017

Conversation

Projects
None yet
2 participants
@evandixon
Collaborator

evandixon commented Jun 24, 2017

I recently learned about targetting multiple frameworks in .Net Standard libraries. The main benefit here is that PKHeX.WinForms and PKHeX.Tests no longer need to carry around the .Net Core DLLs. While it's now an option, I encourage PKHeX.Core to avoid framework-specific compiler directives.

I don't know if PKHaX will work again after this change, although I don't see why not, besides the code changes. (Although to be fair, I didn't see why not when it wasn't working.)

The Windows Team City build is compatible with this change. The Mono build is fixed, but it paused because I expect normal builds will no longer work until this PR is completed.

Target netstanard1.3 and net46
I recently learned about targetting multiple frameworks in .Net Standard libraries. The main benefit here si taht PKHeX.WinForms and PKHeX.Tests no longer need to carry around the .Net Core DLLs. While it's now an option, I encourage PKHeX.Core to avoid framework-specific compiler directives.

@kwsch kwsch merged commit b339dde into master Jun 24, 2017

3 checks passed

Build - Linux Mono (PKHeX) TeamCity build finished
Details
Build - Windows (PKHeX) TeamCity build finished
Details
Build - Windows (PKHeX) - merge TeamCity build finished
Details

@kwsch kwsch deleted the f/core-multi-framework-target branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment