Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ember-cli-sass with postcss #108

Closed
buschtoens opened this issue Jan 22, 2018 · 4 comments
Closed

Replace ember-cli-sass with postcss #108

buschtoens opened this issue Jan 22, 2018 · 4 comments

Comments

@buschtoens
Copy link

@buschtoens buschtoens commented Jan 22, 2018

Would you accept a PR that replaces ember-cli-sass with ember-css-module / postcss? 馃檪

The css files would stay almost the same, I'd only have to swap some keywords here and there.

I would like to get rid of the transient binary dependency in our projects.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Jan 22, 2018

@buschtoens are there any differences in final bundle size, or maintenance costs associated with switching over?

@buschtoens

This comment has been minimized.

Copy link
Author

@buschtoens buschtoens commented Jan 22, 2018

In theory, both processors should yield pretty much the same output.

Regarding maintenance cost one could argue that you now have to keep track of ember-css-modules and a few postcss plugins as opposed to just ember-cli-sass. In practice this never posed a problem for me though. I'm using quite a bunch of plugins across my projects and can't recall having to modify my css in order to stay compatible with upstream changes.

This "could-be disadvantage" is also one of the big selling points. You're not buying in to a monolithic system controlled by an external power. Instead you include just the parts you really need and could even write your own plugins rather simply鈥攕omething that's not possible with Sass.

Obviously I'm trying to sway you over here, but in all honesty, I haven't experienced any down sides so far.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Jan 22, 2018

@buschtoens sounds reasonable enough to me. Happy to accept a PR!

@jrjohnson

This comment has been minimized.

Copy link
Contributor

@jrjohnson jrjohnson commented Sep 7, 2018

FWIW ember-cli-sass v9 now supports Dart which is a JS sass implementation that won't need to be complied so this may not be necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.