Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when setting 'modifiers' in app defaults (environment.js) #111

Closed
enkol opened this issue Feb 14, 2018 · 2 comments
Closed

Warning when setting 'modifiers' in app defaults (environment.js) #111

enkol opened this issue Feb 14, 2018 · 2 comments

Comments

@enkol
Copy link
Contributor

@enkol enkol commented Feb 14, 2018

In my app, i had issues with tooltips gettign trapped within their parents boundaries. I got it fixed by setting modifiers.preventOverflow.boundariesElement: 'viewport'.

I've then added this to config/environment.js, to not have to give it on every tooltip component use:

emberAttacher: {
  modifiers: {
    preventOverflow: {
      boundariesElement:  'viewport'
    }
  }
}

With this, an Unknown property given as an ember-attacher default: modifiers warning comes up for every tooltip initialization.

Is their any harm or risk by setting the modifiers in environment.js? Can we savely add it as modifiers: null to the known/allowed default settings overrides in ember-attachers defaults.js, to get rid of the warning?

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Feb 14, 2018

For sure! PR welcome.

enkol added a commit to enkol/ember-attacher that referenced this issue Feb 15, 2018
kybishop added a commit that referenced this issue Feb 15, 2018
@enkol

This comment has been minimized.

Copy link
Contributor Author

@enkol enkol commented Feb 16, 2018

fixed with #113

@enkol enkol closed this Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.