Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting `arrow: true` in config/environment.js throws error #114

Closed
luxferresum opened this issue Mar 2, 2018 · 5 comments
Closed

setting `arrow: true` in config/environment.js throws error #114

luxferresum opened this issue Mar 2, 2018 · 5 comments

Comments

@luxferresum
Copy link

@luxferresum luxferresum commented Mar 2, 2018

This results in this error:

Cannot set property arrow of [object Object] which has only a getter

The problem is that here this[key] is a proxy with no setter.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Mar 2, 2018

@luxferresum what version of ember are you on? I can set the arrow property just fine in my app.

@luxferresum

This comment has been minimized.

Copy link
Author

@luxferresum luxferresum commented Mar 3, 2018

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Mar 3, 2018

Thanks @luxferresum! I believe this issue is actually from ember-decorators, which don't have full ember 3.0 support yet, and ember-decorators is used in the positioning library, ember-popper.

I'm going to see if I can fix the bug in ember-decorators this weekend. If not, I'll be ripping it out on Sunday/Monday and pushing a new version of ember-popper + ember-attacher

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Mar 14, 2018

This will be fixed in the next release, just need ember-decorators/argument#62 to be accepted, then a release chain from there to ember-popper :)

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Mar 20, 2018

Fixed in #102

@kybishop kybishop closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.