Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation: 'fill' is not compatible with arrow: true #126

Closed
mmun opened this issue Apr 13, 2018 · 4 comments
Closed

Animation: 'fill' is not compatible with arrow: true #126

mmun opened this issue Apr 13, 2018 · 4 comments

Comments

@mmun
Copy link

@mmun mmun commented Apr 13, 2018

If you specify the global options

    emberAttacher: {
      animation: 'shift',
    },

and invoke a tooltip with {{attach-tooltip arrow=true}}, you get a warning a warning that says

Animation: 'fill' is not compatible with arrow: true

This occurs because the setter on arrow is triggered before the global animation has been applied.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Jun 11, 2018

@munn reported that this is still occuring. Need to think about how to fix this...

@kybishop kybishop reopened this Jun 11, 2018
@morgano86

This comment has been minimized.

Copy link

@morgano86 morgano86 commented Jul 19, 2018

Any update on this?

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Jul 19, 2018

I think I have a roundabout way of fixing this.... will attempt a fix over the next two days

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Jul 23, 2018

Pretty sure I've got a fix! Want to take some time to actually experiment with it and provide some tests before pushing it through, but I'm quite confident about this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.