Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation support for more Popper.js placements (right-start, etc.) #134

Closed
lougreenwood opened this issue May 13, 2018 · 2 comments
Closed

Animation support for more Popper.js placements (right-start, etc.) #134

lougreenwood opened this issue May 13, 2018 · 2 comments

Comments

@lougreenwood
Copy link

@lougreenwood lougreenwood commented May 13, 2018

Popper.js adds variations to placements - however, these don't seem to work with ember-attacher...?

@lougreenwood

This comment has been minimized.

Copy link
Author

@lougreenwood lougreenwood commented May 13, 2018

Actually, it seems that they do work, bottom-end for example.

However, it seems that when a variation is added, then the popover loses it's animation

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented May 14, 2018

Hey @lougreenwood, this is because the animation CSS was built upon the base placements https://github.com/kybishop/ember-attacher/blob/master/addon/styles/_mixins.scss#L20

More than happy to accept a PR for additional animations!

@kybishop kybishop changed the title Popper.js variations? Animation support for more Popper.js placements (right-start, etc.) May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.