Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Could not find module `ember-native-dom-helpers` imported from `ember-attacher/is-visible` #140

Closed
Turbo87 opened this issue May 30, 2018 · 1 comment

Comments

@Turbo87
Copy link

@Turbo87 Turbo87 commented May 30, 2018

It appears that the isVisible() test helper unconditionally imports code from ember-native-dom-helpers, but ember-attacher has no dependency on that addon. We have remove the addon lately and replaced it by @ember/test-helpers, but now QUnit is complaining about this import in ember-attacher.

/cc @pzuraq

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Oct 12, 2018

dangit, I'll see if I can find a good solution for this 🤔 . I honestly might just strip it in favor of telling people how to make their own isVisible helper, which they can then match with whatever backing test-lib they want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.