Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few files missing 404 errors #142

Closed
vivian-ho opened this issue Jul 19, 2018 · 6 comments
Closed

Few files missing 404 errors #142

vivian-ho opened this issue Jul 19, 2018 · 6 comments

Comments

@vivian-ho
Copy link

@vivian-ho vivian-ho commented Jul 19, 2018

These are errors from Express.js:
GET /assets/ember-attacher.css 404 9.479 ms - 29
GET /assets/ember-attacher.css 404 9.479 ms - 29
GET /assets/ember-attacher.css 404 6.158 ms - 29
GET /assets/ember-attacher.css 404 6.158 ms - 29
GET /assets/ember-attacher.js 404 5.296 ms - 29
GET /assets/ember-attacher.js 404 5.296 ms - 29
GET /assets/ember-attacher.js 404 5.730 ms - 29
GET /assets/ember-attacher.js 404 5.730 ms - 29
GET /assets/ember-attacher.css.map 404 22.173 ms - 29
GET /assets/ember-attacher.css.map 404 22.173 ms - 29

Please fix.

@vivian-ho

This comment has been minimized.

Copy link
Author

@vivian-ho vivian-ho commented Jul 25, 2018

@acorncom

This comment has been minimized.

Copy link

@acorncom acorncom commented Jul 25, 2018

@vivian-ho are you able to publish a reproduction repo? It's pretty hard to work out what you are hitting based on the above ...

@vivian-ho

This comment has been minimized.

Copy link
Author

@vivian-ho vivian-ho commented Jul 26, 2018

I created a brand new Ember app and couldn't repro. This issue could be just specific to our own env (we're still on Ember 2). It'll be a while before we can upgrade. Wondering if you can have this addon produce the resourcemaps like popper in the image below?
popper

@acorncom

This comment has been minimized.

Copy link

@acorncom acorncom commented Jul 26, 2018

I believe resource map generation should be handled by Ember automatically, are you wanting them for production or just in development? There's more info here about producing them when in production ... https://ember-cli.com/user-guide/#source-maps

@vivian-ho

This comment has been minimized.

Copy link
Author

@vivian-ho vivian-ho commented Jul 26, 2018

We have sourcemaps enabled in ember-cli-build.js, and it does generate for others (like the main app, and popper) but not ember-attacher.

@vivian-ho

This comment has been minimized.

Copy link
Author

@vivian-ho vivian-ho commented Jul 26, 2018

I added css support for sourcemaps and 404 is gone now.

@vivian-ho vivian-ho closed this Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.