Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in Ember 3.9 #164

Closed
richard-viney opened this issue Apr 14, 2019 · 4 comments · Fixed by #165
Closed

Deprecation warning in Ember 3.9 #164

richard-viney opened this issue Apr 14, 2019 · 4 comments · Fixed by #165

Comments

@richard-viney
Copy link
Collaborator

@richard-viney richard-viney commented Apr 14, 2019

The computed-property.override deprecation added in Ember 3.9 is being triggered by

this.set('_shouldRender', true);
.

Looking at the code this should only need a minor change - I'll do a PR for it shortly.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

@richard-viney richard-viney commented Apr 14, 2019

Fixed by #165.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

@richard-viney richard-viney commented Apr 14, 2019

@luketheobscure Are you now a maintainer who could merge this and do a release?

@luketheobscure

This comment has been minimized.

Copy link
Collaborator

@luketheobscure luketheobscure commented Apr 15, 2019

@richard-viney I am. It looks like Kyle is still somewhat involved, but if he isn't able to I would be happy to merge this and release it. Thanks for helping out!

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

@richard-viney richard-viney commented Apr 17, 2019

Great, #165 is there and ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.