Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isShown, showOn, and hideOn do not work together #25

Closed
rwwagner90 opened this issue Aug 18, 2017 · 2 comments
Closed

isShown, showOn, and hideOn do not work together #25

rwwagner90 opened this issue Aug 18, 2017 · 2 comments

Comments

@rwwagner90
Copy link
Collaborator

@rwwagner90 rwwagner90 commented Aug 18, 2017

If I use showOn='click' and hideOn='click', then passing isShown=false will not force it to close, however, if I set showOn='none' and hideOn='none' and try to use isShown it does toggle visibility, but then it is rendered in the wrong location, not tied to its parent.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 24, 2017

@rwwagner90 are you still experiencing this issue? I've patched up the tests and all looks well to me both there and in the dummy app.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 28, 2017

This should be fixed by #48. Feel free to re-open if you're still experiencing the issue.

@kybishop kybishop closed this Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.