Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic CSS selectors conflicts with other CSS libs #28

Closed
GCheung55 opened this issue Aug 21, 2017 · 5 comments
Closed

Generic CSS selectors conflicts with other CSS libs #28

GCheung55 opened this issue Aug 21, 2017 · 5 comments

Comments

@GCheung55
Copy link
Contributor

@GCheung55 GCheung55 commented Aug 21, 2017

Generic CSS selectors like .tooltip conflicts with libs like foundation-sites.

Would it make sense to name them more specific to this addon or make all the CSS a mixin?

@GCheung55

This comment has been minimized.

Copy link
Contributor Author

@GCheung55 GCheung55 commented Aug 21, 2017

There's also an alternative SCSS loading so that the SCSS can be manually imported, giving developers more control: https://github.com/aexmachina/ember-cli-sass/blob/master/README.md#alternative-addon-usage

@kybishop, How about a combination of the alternative SCSS loading and more specific names as a solution?

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Aug 21, 2017

@GCheung55 we can definitely do something about this. I'm not sure if @kybishop wants to support apps that do not use SASS or not, but if not, we can do the import way, if he does, I would say we should expose a config option to includeCSS, so you can opt out.

@GCheung55

This comment has been minimized.

Copy link
Contributor Author

@GCheung55 GCheung55 commented Aug 21, 2017

@rwwagner90 Okay. In the meantime, I submitted a PR to rename the selectors so at least it doesn't conflict.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 22, 2017

Fixed in #31

@kybishop kybishop closed this Aug 22, 2017
@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 22, 2017

@rwwagner90 id love to do a config option in the long term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.