Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding aria-describedby attribute to target? #37

Closed
GCheung55 opened this issue Aug 24, 2017 · 6 comments
Closed

Adding aria-describedby attribute to target? #37

GCheung55 opened this issue Aug 24, 2017 · 6 comments
Milestone

Comments

@GCheung55
Copy link
Contributor

@GCheung55 GCheung55 commented Aug 24, 2017

Should the aria-describedby attribute be ember-attacher's responsibility to add to the target?

@GCheung55 GCheung55 changed the title Should adding aria-describedby attribute to target? Adding aria-describedby attribute to target? Aug 24, 2017
@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 25, 2017

I realize that ember-tooltips does this, but my first instinct is that we should not follow suite.

I'm wary of adding an implicit side-effect that modifies something outside of our component.

Seems like we should avoid touching things outside the {{ember-attacher}} to avoid surprising people with a side effect they might not want.

Very open to discussion on this; I fully admit to not knowing too many details about aria support.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 25, 2017

Only an hour in and I've changed my mind on this. Seems like it is standard behavior across tooltip libs to modify the target. I think we should add aria-describedby by default, but have an option to exclude it for things like popovers.

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Aug 25, 2017

@kybishop perhaps we should have two separate components for popover and tooltip, so we could exclude it by default? ember-tooltips has two components, so might not be terrible. Could also add classes by default then of ember-attacher-tooltip and ember-attacher-popover, based on which component you use.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 25, 2017

@rwwagner90 that sounds reasonable. We could make a mixin that does basically everything, then have a few additional functionalities in the specific components.

@GCheung55

This comment has been minimized.

Copy link
Contributor Author

@GCheung55 GCheung55 commented Aug 25, 2017

Just adding a bit more info, https://www.w3.org/TR/wai-aria-practices/#tooltip also mentions using aria-describedby.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 28, 2017

I have a gameplan for this, will hopefully have a custom tooltip component in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.