Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use class instead of popperClass #41

Closed
kybishop opened this issue Aug 25, 2017 · 2 comments
Closed

use class instead of popperClass #41

kybishop opened this issue Aug 25, 2017 · 2 comments
Milestone

Comments

@kybishop
Copy link
Owner

@kybishop kybishop commented Aug 25, 2017

Just like in ember-popper. This can be done by making the component tagless and simply passing the class to the ember-popper instance.

@kybishop

This comment has been minimized.

Copy link
Owner Author

@kybishop kybishop commented Aug 25, 2017

I have a working branch that both makes ember-attacher tagless and switches popperClass to class. Blocked on kybishop/ember-popper#31

@kybishop

This comment has been minimized.

Copy link
Owner Author

@kybishop kybishop commented Aug 26, 2017

Implemented in #45

@kybishop kybishop closed this Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.