Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover/tooltip doesn't reposition on sharp browser resize. #43

Closed
GCheung55 opened this issue Aug 25, 2017 · 6 comments · Fixed by #61
Closed

Popover/tooltip doesn't reposition on sharp browser resize. #43

GCheung55 opened this issue Aug 25, 2017 · 6 comments · Fixed by #61

Comments

@GCheung55
Copy link
Contributor

@GCheung55 GCheung55 commented Aug 25, 2017

I'm seeing an issue with a visible popover/tooltip positioning.

When the browser is resized sharply/quickly, the popover/tooltip isn't repositioned correctly.

tooltip-issue

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 26, 2017

Interesting. This is almost certainly an issue with popper.js, since that is the library we use for positioning. I'll investigate and see about filling an issue there if one doesn't exist already. @GCheung55 you're more than welcome to take the lead on that 😁

@FezVrasta

This comment has been minimized.

Copy link

@FezVrasta FezVrasta commented Aug 26, 2017

There's already a PR ready to fix it

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 26, 2017

@FezVrasta I'm consistently amazed by your hard work. Somehow you found this and already have a fix ready to go before we even filed an issue 😁

Would the PR in question be popperjs/popper-core#402 ?

Just want to track it so we can bump our popper.js dependency once the relevant PR is merged.

@FezVrasta

This comment has been minimized.

Copy link

@FezVrasta FezVrasta commented Aug 26, 2017

Yes that's it. I need some more feedback before merging it tho :-(

@kybishop kybishop changed the title Bug? Visible popover/tooltip doesn't reposition on sharp browser resize. Popover/tooltip doesn't reposition on sharp browser resize. Aug 30, 2017
@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Aug 31, 2017

@GCheung55 I'm just waiting on ember-cli to be released before doing a dependency bump in ember-popper, including popper.js. If this is super bothersome feel free to ping me and I can release earlier.

@GCheung55

This comment has been minimized.

Copy link
Contributor Author

@GCheung55 GCheung55 commented Aug 31, 2017

@kybishop no worries. It's an edge case my team has accepted esp since it's fixed in popper.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.