Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hideOn and showOn broken when undefined #76

Closed
rwwagner90 opened this issue Oct 17, 2017 · 2 comments
Closed

hideOn and showOn broken when undefined #76

rwwagner90 opened this issue Oct 17, 2017 · 2 comments

Comments

@rwwagner90
Copy link
Collaborator

@rwwagner90 rwwagner90 commented Oct 17, 2017

If you pass an undefined hideOn or showOn, we should probably grab the defaults instead of using undefined. Right now it blows up on trying to do .split.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Oct 18, 2017

Agreed on grabbing the defaults for undefined. I'm pondering what we should do for null though...

I think we should assume the user is purposely asking for no hideOn or showOn actions.

@rwwagner90

This comment has been minimized.

Copy link
Collaborator Author

@rwwagner90 rwwagner90 commented Oct 18, 2017

@kybishop yeah undefined I would use defaults and null I would disable it. Alternatively, we could throw errors for undefined and require people to define something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.