Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes my builds to fail? #87

Closed
gojefferson opened this issue Nov 22, 2017 · 6 comments
Closed

Causes my builds to fail? #87

gojefferson opened this issue Nov 22, 2017 · 6 comments

Comments

@gojefferson
Copy link

@gojefferson gojefferson commented Nov 22, 2017

I have no idea why this would be happening, but after installing the addon, my builds are failing.

Here's the terminal output

web> ember install ember-attacher
Yarn: Installed ember-attacher
Installed addon package.
web> ember deploy staging --activate=true
ember-cli-sentry will not be loaded from bower installation
cleaning up...
- build failed
Error: The Broccoli Plugin: [Fingerprint] failed with:
TypeError: Cannot read property '2' of null
    at AssetRewrite.rewriteAssetPath (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rewrite/index.js:127:91)
    at AssetRewrite.processString (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rewrite/index.js:167:24)
    at AssetRewrite.processFile (/Users/Jeff1/cf_repos/web/node_modules/broccoli-filter/index.js:165:31)
    at asyncProcessFile (/Users/Jeff1/cf_repos/web/node_modules/broccoli-filter/index.js:122:21)
    at tryCatch (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:538:13)
    at /Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:606:14
    at flush (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:2415:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickDomainCallback (internal/process/next_tick.js:122:9)

The broccoli plugin was instantiated at:
    at Fingerprint.Plugin (/Users/Jeff1/cf_repos/web/node_modules/broccoli-plugin/index.js:7:31)
    at Fingerprint.Filter [as constructor] (/Users/Jeff1/cf_repos/web/node_modules/broccoli-filter/index.js:34:10)
    at new Fingerprint (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rev/lib/fingerprint.js:21:10)
    at Fingerprint (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rev/lib/fingerprint.js:16:12)
    at new AssetRev (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rev/lib/asset-rev.js:37:26)
    at AssetRev (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rev/lib/asset-rev.js:7:12)
    at Class.postprocessTree (/Users/Jeff1/cf_repos/web/node_modules/broccoli-asset-rev/index.js:31:40)
    at projectOrAddon.addons.reduce (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/utilities/addon-process-tree.js:6:25)
    at Array.reduce (native)
    at addonProcessTree (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)
    at EmberApp.addonPostprocessTree (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/broccoli/ember-app.js:661:12)
    at EmberApp.toTree (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/broccoli/ember-app.js:1814:17)
    at module.exports (/Users/Jeff1/cf_repos/web/ember-cli-build.js:76:14)
    at Builder.setupBroccoliBuilder (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/models/builder.js:56:19)
    at new Builder (/Users/Jeff1/cf_repos/web/node_modules/ember-cli/lib/models/builder.js:30:10)
    at CoreObject.build (/Users/Jeff1/cf_repos/web/node_modules/ember-cli-deploy-build/index.js:33:23)
    at Object.fn (/Users/Jeff1/cf_repos/web/node_modules/ember-cli-deploy/lib/tasks/pipeline.js:93:21)
    at Pipeline._notifyPipelinePluginHookExecution (/Users/Jeff1/cf_repos/web/node_modules/ember-cli-deploy/lib/models/pipeline.js:173:19)
    at tryCatch (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:538:13)
    at /Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:606:14
    at flush (/Users/Jeff1/cf_repos/web/node_modules/rsvp/dist/rsvp.js:2415:5)

Pipeline aborted
web>
@gojefferson gojefferson changed the title Cause my builds to fail Causes my builds to fail? Nov 22, 2017
@rwwagner90

This comment has been minimized.

Copy link
Collaborator

@rwwagner90 rwwagner90 commented Nov 23, 2017

I don't see anything in that output that mentions ember-attacher or ember-popper, I don't think. Did I miss a line where it refers to that? If it doesn't refer to either, it's likely a version mismatch issue between other packages. I would need a sample repo to look at the deps and see if I can see anything.

@kybishop

This comment has been minimized.

Copy link
Owner

@kybishop kybishop commented Nov 23, 2017

Hey @gojefferson, there was an issue with dev builds in version 0.12.0 that should be fixed in 0.12.1. Can you verify that 0.12.1 is being installed?

If it is, what version of ember are you using, and are you explicitly specifying an ember-popper version? (You shouldn't have to be, just want to rule out a broken older version)

@gojefferson

This comment has been minimized.

Copy link
Author

@gojefferson gojefferson commented Nov 23, 2017

Just checked again today. Running ember install ember-attacher installs ember-attacher 0.12.1. I don't have a specific version of ember-popper listed in package.json, but according to yarn, I've got 0.7.3 from ember-attacher.

I'm running Ember 2.16.2.

What's odd is that I'm able to run my app on localhost - I just can't deploy it. I'm thinking there's some conflict with an ember-cli-deploy plugin, but it's very hard to figure out why this would happen. We use a lot of addons and haven't seen this issue before.

@gojefferson

This comment has been minimized.

Copy link
Author

@gojefferson gojefferson commented Nov 23, 2017

Ah, I think I found something. I added some logging:

The deploy fails precisely at this point:

      in node_modules/broccoli-asset-rewrite/index.js
      ------
      assetPath: popper.js.map
      replacementPath: assets/popper.js-ef3a9dd1461e0a922e759eaa9683f01c.map

I am able to deploy if I comment out line 22 in ember-popper/index.js:

// public: ['popper.js.map']
@gojefferson

This comment has been minimized.

Copy link
Author

@gojefferson gojefferson commented Nov 23, 2017

I opened a PR in ember-popper to remove that line.

@gojefferson

This comment has been minimized.

Copy link
Author

@gojefferson gojefferson commented Nov 23, 2017

I found the source of the problem in my config. We have to do some weird things with maps in our builds. I made a change, and I'm now able to deploy. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.