Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #128

Merged
merged 3 commits into from Apr 23, 2018
Merged

Improve README #128

merged 3 commits into from Apr 23, 2018

Conversation

@mostafa-sakhiri
Copy link
Contributor

mostafa-sakhiri commented Apr 20, 2018

As I did not understand why arrows didn't work the first time, I think it could be better if this was specified in the documentation.

mostafa-sakhiri and others added 3 commits Apr 20, 2018
@kybishop kybishop merged commit b9ef250 into kybishop:master Apr 23, 2018
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kybishop

This comment has been minimized.

Copy link
Owner

kybishop commented Apr 23, 2018

Thanks @mostafa-sakhiri! We have a (IMO) nice looking popover in the dummy app that uses a custom background color, and has its arrow styled to match. I made a "Styles" section and linked to the CSS, as well as mentioned the bit about arrows.

@mostafa-sakhiri

This comment has been minimized.

Copy link
Contributor Author

mostafa-sakhiri commented Apr 23, 2018

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.