Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(race conditions with lazyRender and showDelay) #138

Merged
merged 1 commit into from May 25, 2018

Conversation

@kybishop
Copy link
Owner

kybishop commented May 24, 2018

Fixes #137 and #125

@@ -561,7 +562,7 @@ export default Component.extend({
// If cursor is not on the attachment or target, hide the popper
if (!target.contains(event.target)
&& !(this.get('isOffset') && this._isCursorBetweenTargetAndAttachment(event))
&& !this._popperElement.contains(event.target)) {
&& (this._popperElement && !this._popperElement.contains(event.target))) {

This comment has been minimized.

Copy link
@kybishop

kybishop May 25, 2018

Author Owner

TODO(kjb) I don't believe this is necessary anymore. Remove before merging

@kybishop kybishop force-pushed the avoid-lazy-render-race-condition branch from 22d3963 to 5ba6fe4 May 25, 2018
@kybishop kybishop merged commit 8f5f820 into master May 25, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@kybishop kybishop deleted the avoid-lazy-render-race-condition branch May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.