Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: works with placement modifiers (start/end) #143

Merged
merged 1 commit into from Jul 25, 2018

Conversation

@urbany
Copy link
Contributor

urbany commented Jul 21, 2018

Enable ember-attacher to work with the following placements:

  • bottom-start
  • bottom-end
  • left-start
  • left-end
  • right-start
  • right-end
  • top-start
  • top-end

Fixes #134 #139

@kybishop

This comment has been minimized.

Copy link
Owner

kybishop commented Jul 23, 2018

Nice! I'll have a chance to review this tomorrow

@@ -242,7 +242,7 @@
options=placementOptions
searchEnabled=false
selected=service.placement
triggerClass="button medium"
triggerClass="button large"

This comment has been minimized.

Copy link
@kybishop

kybishop Jul 25, 2018

Owner

Was there a reason this was made "large"?

This comment has been minimized.

Copy link
@kybishop

kybishop Jul 25, 2018

Owner

Ah I see, the options are much larger now.

@kybishop

This comment has been minimized.

Copy link
Owner

kybishop commented Jul 25, 2018

Thanks @urbany! I'm hoping to release this along with another change today

@kybishop kybishop merged commit 4661cfe into kybishop:master Jul 25, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.