Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-cli-sass #147

Merged
merged 1 commit into from Sep 10, 2018
Merged

Update ember-cli-sass #147

merged 1 commit into from Sep 10, 2018

Conversation

@jrjohnson
Copy link
Contributor

jrjohnson commented Sep 7, 2018

The latest version of ember-cli-sass no longer requires node-sass and
uses sass (the dart sass JS build) by default. Usually this would be
added by the application requiring ember-cli-sass, but since this is a
dependency of this addon I added it to dependencies as well. Apps can
still override their sass implementation, this just ensures that
something is available to the app. We could also put sass into devDependencies and add some instructions for addon consumers to install it themselves.

Fixes #108

The latest version of ember-cli-sass no longer requires node-sass and
uses sass (the dart sass JS build) by default. Usually this would be
added by the application requiring ember-cli-sass, but since this is a
dependency of this addon I added it to dependencies as well. Apps can
still override their sass implementation, this just ensures that
something is available to the app.
@kybishop kybishop merged commit 3ad73ee into kybishop:master Sep 10, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jrjohnson jrjohnson deleted the jrjohnson:update-cli-sass branch Sep 10, 2018
@Turbo87

This comment has been minimized.

Copy link

Turbo87 commented Sep 17, 2018

unfortunately this means that even if dart-sass is used npm/yarn would have to compile this native dependency... 🤔

@jrjohnson

This comment has been minimized.

Copy link
Contributor Author

jrjohnson commented Sep 21, 2018

@Turbo87 do you mean compile dart-sass? It is written in dart but distributed as pure JS in sass and the docs say

This package is a distribution of Dart Sass, compiled to pure JavaScript with no native code or external dependencies. It provides a command-line sass executable and a Node.js API.

So there shouldn't be anything to compile - unless I'm not understanding a piece of this (which is quite possible!)

@Turbo87

This comment has been minimized.

Copy link

Turbo87 commented Sep 21, 2018

ah, sorry I got confused by the package names 🙈

@jrjohnson

This comment has been minimized.

Copy link
Contributor Author

jrjohnson commented Sep 28, 2018

@kybishop sorry for the ping, just wondering if you can release with this change. This is my last dependency that still requires node-sass compilation. Thanks.

@kybishop

This comment has been minimized.

Copy link
Owner

kybishop commented Sep 28, 2018

@jrjohnson released! Sorry for the delay, life has been too busy these past few months.

@jrjohnson

This comment has been minimized.

Copy link
Contributor Author

jrjohnson commented Sep 28, 2018

Real life should always come first! Thanks for the release and sorry if I interrupted anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.