Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix computed-property.override deprecation in Ember 3.9 #165

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@richard-viney
Copy link
Collaborator

richard-viney commented Apr 14, 2019

Fixes #164.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

richard-viney commented Apr 17, 2019

@luketheobscure Have rebased this PR on the latest master and the test suite is passing (I believe the previous test failure was spurious and nothing to do with the changes in this branch).

If we could merge this and then do a release that'd be great, presumably as v0.13.11 as there are no breaking changes since 0.13.10.

@luketheobscure luketheobscure merged commit b97aaa7 into kybishop:master Apr 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@luketheobscure

This comment has been minimized.

Copy link
Collaborator

luketheobscure commented Apr 19, 2019

Thanks @richard-viney! I'll try to give this addon some attention early next week.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

richard-viney commented Apr 19, 2019

Thanks, a release to NPM would be great.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

richard-viney commented Apr 24, 2019

Haven't any issues with running this off master in our app so far this week.

@richard-viney

This comment has been minimized.

Copy link
Collaborator Author

richard-viney commented Apr 28, 2019

@luketheobscure Would it be possible to get a v0.13.11 or a v0.14 release this week?

urbany added a commit to urbany/ember-attacher that referenced this pull request Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.