Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lazyRender and isShown set manually) (#176) #177

Merged
merged 1 commit into from Nov 13, 2019

Conversation

@ctjhoa
Copy link
Contributor

ctjhoa commented Oct 22, 2019

If you wanted to manually toggle isShown and still have lazyRender this boolean was never set as it was only used in _showAfterDelay function.
We need to update it also in _show method which is called by the isShown observer.

This PR demonstrate and fix this issue. (#176 )

@tylerturdenpants tylerturdenpants merged commit 71386fe into kybishop:master Nov 13, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ctjhoa

This comment has been minimized.

Copy link
Contributor Author

ctjhoa commented Nov 13, 2019

This has been introduced with #138

ctjhoa added a commit to ctjhoa/ember-attacher that referenced this pull request Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.