Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class to know if popover has arrow #181

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@ctjhoa
Copy link
Contributor

ctjhoa commented Nov 14, 2019

Ok so I need to give you a bit of context on how this PR is important for our product.

We use ember-attacher to create such menu:
2019-11-14-151650_439x362_scrot

By default, ember-attacher has 10px spacing between the popover and the target:
2019-11-14-152625_700x352_scrot

This spacing is the space needed for arrow

2019-11-14-153151_660x322_scrot

and is due to this CSS rule

transform: translateY(10px) rotateX(0);

IMHO, ember-attacher should not add spacing if arrow are disabled. However, if we don't want to introduce breaking change. The only way is to provide users a CSS class which show if popover has arrow or not. With this PR, we could override the CSS rule to remove the initial spacing.

@ctjhoa

This comment has been minimized.

Copy link
Contributor Author

ctjhoa commented Nov 14, 2019

In previous ember-attacher version (< 0.13.7) we could prevent spacing using placement modifiers (eg. bottom-start) but this was fixed with:
#143

@tylerturdenpants tylerturdenpants merged commit d32750a into kybishop:master Nov 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.