Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether component is not destroyed inside `next` #29

Merged
merged 1 commit into from Aug 21, 2017

Conversation

@krasnoukhov
Copy link
Contributor

krasnoukhov commented Aug 21, 2017

I'm not sure exactly how to reproduce this, but we have multiple ember-attacher instances on a page and getting "TypeError: Cannot read property 'style' of null" error pretty regularly.

I guess it would make sense to check for isDestroyed anyway since we're already in a new Run Loop.

@rwwagner90

This comment has been minimized.

Copy link
Collaborator

rwwagner90 commented Aug 21, 2017

@krasnoukhov have you tested this change and it fixes your problem?

@krasnoukhov

This comment has been minimized.

Copy link
Contributor Author

krasnoukhov commented Aug 21, 2017

@rwwagner90 Yeah it does!

@rwwagner90 rwwagner90 merged commit 9343ef4 into kybishop:master Aug 21, 2017
@rwwagner90

This comment has been minimized.

Copy link
Collaborator

rwwagner90 commented Aug 21, 2017

Thanks @krasnoukhov! Just released 0.8.3 with the fix.

@krasnoukhov

This comment has been minimized.

Copy link
Contributor Author

krasnoukhov commented Aug 21, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.