Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tagless component) popperClass is now class and id is passed to attachment #45

Merged
merged 1 commit into from Aug 26, 2017

Conversation

@kybishop
Copy link
Owner

kybishop commented Aug 26, 2017

Implements #41
Paves the way for #37

I'm really happy with the changes introduced here:

  1. We can now pass class and id directly to the popper element
  2. No more ghost element where the {{ember-attacher}} was declared
  3. Much cleaner tests now that we don't rely on didInsertElement
  4. Greatly simplified internals now that we grab target from ember-popper instead of recalculating it ourselves
@kybishop kybishop merged commit 22bde8f into master Aug 26, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@kybishop kybishop deleted the tagless-component branch Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.