Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RAF for animations #63

Merged
merged 2 commits into from Sep 7, 2017
Merged

Use RAF for animations #63

merged 2 commits into from Sep 7, 2017

Conversation

@kybishop
Copy link
Owner

kybishop commented Sep 7, 2017

This makes things buttery smooth by greatly improving performance. It also fixes, once and for all, strange positioning issues that spur from display: none being toggled on the same repaint that animations take place.

@kybishop kybishop force-pushed the use-RAF-for-animations branch from 14a9179 to 00733e0 Sep 7, 2017
@kybishop kybishop force-pushed the use-RAF-for-animations branch from 00733e0 to b705c22 Sep 7, 2017
@kybishop

This comment has been minimized.

Copy link
Owner Author

kybishop commented Sep 7, 2017

Testing a component that uses requestAnimationFrame is not a good time o_O.

Will have to dig into why the 2.12 tests are failing.

@kybishop

This comment has been minimized.

Copy link
Owner Author

kybishop commented Sep 7, 2017

Merging this and fixing tests later. There's no reason this would break things in prior versions of ember, we're just hitting limitations of the test framework.

@kybishop kybishop merged commit e87f77b into master Sep 7, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
@kybishop kybishop deleted the use-RAF-for-animations branch Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.