Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removes setBaseURL Calls #98

Closed
wants to merge 1 commit into
from

Conversation

2 participants

setBaseURL doesn't exist as a method and anyone trying to use this library has always (or at least as long I've been using it for the past year+) had to just comment out those lines in order to compile. It seems like whatever was supposed to be accomplished with those lines is handled with the initWithBaseURL calls.

Owner

kylebrowning commented Sep 24, 2013

It should exist on the DIOSSessions object, and its used if you need to connect to more than one drupal instance for your app.

@property (readwrite, nonatomic, retain) NSURL *baseURL;

The property exists, yes. There is no setBaseURL method.

Owner

kylebrowning commented Sep 24, 2013

It should be there with @synthesize baseURL is my point.

Ah, right, I was actually mistaken in my last response. My compiler isn't recognizing that baseURL is a property at all, which is why I assumed it was unnecessary code. That's why the person who opened #77 was so confused when his issue was closed and why those lines were commented out by #82.

I'll close this and come up with something better, or guidance for future Google searchers.

@stickywes stickywes closed this Sep 24, 2013

@kylebrowning kylebrowning reopened this Sep 24, 2013

Owner

kylebrowning commented Sep 24, 2013

Soo, really this pull request just needs to add this property to DIOSSession, and then synthesize, and its fixed.

Yeah, that's all it took for me. It looks like in the AFHTTPClient header has that property declared as readonly (which is redeclared in the implementation file), so just redeclaring the property is probably enough.

Owner

kylebrowning commented Sep 24, 2013

If you want to test that, open that pull request, ill gladly merge.

Owner

kylebrowning commented Sep 25, 2013

I fixed this and pushed it 2.0.4

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment