Variadic argument validation #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylef
reviewed
Nov 24, 2016
Sources/ArgumentDescription.swift
Outdated
|
|
||
| open class VariadicArgument<T : ArgumentConvertible> : ArgumentDescriptor { | ||
| public typealias ValueType = [T] | ||
| public typealias Validator = (T) throws -> T |
Owner
There was a problem hiding this comment.
I think the validator should take ValueType (Array of Value) instead of each individual Value. You might wish to validate the set together, for example the amount of them, or the values for uniqueness.
What do you think about changing the validator to be an array of values?
Collaborator
Author
|
@kylef any news on when you'd be able to release 0.6? Would be nice to be able to use the new features in SwiftGen. |
Owner
|
@djbe I'll be traveling today, I'll try push a release out tomorrow or Monday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a parameter to the
VariadicArgumenttype to make it more consistent with theArgumenttype.