Fix ambiguous XCTest.tearDown swizzle #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kylef |
|
Can we get a release with these changes? |
|
You could use this for now: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue occurring with Xcode 13 that prevents this project from building.
Xcode has trouble determining which
XCTest.tearDownis referred to, the class or the instance method. As an alternative I initially suggestedSelector("tearDown")which will use the instance method and resolve the issue. However, for that change Xcode displays a warning, and suggests the change in this PR as an alternative.I have tested the change on Xcode 13 and an old Xcode 12.2 beta, on both it compiles and tests pass.
Closes #119