Trouble with has_class or Array.__contains__

[rmhsilva]

refract.py/refract/contrib/apielements.py

Line 19 in 3a5513d

def has_class(class_name):

I'm experiencing this:

In []: type(element)
Out[]: refract.contrib.apielements.Category

In []: element.classes
Out[]: <Array content=[<String content='api'>]>

In []: "api" in element.classes
Out[]: False

Which I think makes apielements.has_class fail, and, in turn, ParseResult.api, and friends.

test.apib:

FORMAT: 1A9

# Test

Drafter (v4.0.0-pre.2) generates the following, which, when deserialised results in the above behaviour.

{
  "element": "parseResult",
  "content": [
    {
      "element": "category",
      "meta": {
        "classes": {
          "element": "array",
          "content": [
            {
              "element": "string",
              "content": "api"
            }
          ]
        },
        "title": {
          "element": "string",
          "content": "Test"
        }
      },
      "attributes": {
        "metadata": {
          "element": "array",
          "content": [
            {
              "element": "member",
              "meta": {
                "classes": {
                  "element": "array",
                  "content": [
                    {
                      "element": "string",
                      "content": "user"
                    }
                  ]
                }
              },
              "content": {
                "key": {
                  "element": "string",
                  "content": "FORMAT"
                },
                "value": {
                  "element": "string",
                  "content": "1A9"
                }
              }
            }
          ]
        }
      },
      "content": []
    }
  ]
}

[rmhsilva]

Right, a bit more investigation, I think it's a bug in the JSON deserialiser.

Here is some POC

#!/usr/bin/env python3

import refract
from refract.json import JSONDeserialiser
from refract.contrib.apielements import registry

JSON = """
{
  "element": "parseResult",
  "content": [
    {
      "element": "category",
      "meta": {
        "classes": {
          "element": "array",
          "content": [
            {
              "element": "string",
              "content": "api"
            }
          ]
        }
      }
    }
  ]
}
"""

def fails():
    deserialiser = JSONDeserialiser(registry=registry)
    parseResult = deserialiser.deserialise(JSON)

    # Should be type Attributes:
    print('Attributes type:', type(parseResult.children[0].classes[0].attributes))

    # Should be True:
    print("api" in parseResult.children[0].classes)

    # Should not throw StopIteration:
    print(parseResult.api)


if __name__ == '__main__':
    fails()

Looks like the problem is in json.deserialise_attributes - it returns a dict, rather than Attributes.

[kylef]

You're right, I've fixed this problem in ef6726b if you want to give that a go

[rmhsilva]

Nice one, thanks @kylef.