Implement insert_batch as described in docs #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already implement in the mysql driver...
Owner
|
Thanks for the PR. I'll get this patched in ASAP. |
Author
|
It works for me, but you might want to add a test case. When will you be releasing the next version? I will promisify it, and have been holding back on working on the current version. |
Owner
|
I'm hoping to have v2 out on August 15th. |
Owner
|
@Flamenco The code is being heavily-refactored to use ES2017 class syntax. You can see the progress being made (and the new code structure) if you look at the |
Owner
|
I'm going to have to manually merge this into the v2 branch since I can't pull this request into it (too many changes). Looks good--thanks for the work you put into it. |
kylefarris
pushed a commit
that referenced
this pull request
Jul 26, 2018
Author
|
Closing this as it is fixed in v2 |
kylefarris
pushed a commit
that referenced
this pull request
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already implemented in the mysql driver...