Skip to content
This repository was archived by the owner on May 5, 2020. It is now read-only.

Commit 1e24b97

Browse files
committed
Added aria landmark roles
1 parent 9b7d4b0 commit 1e24b97

File tree

8 files changed

+26
-24
lines changed

8 files changed

+26
-24
lines changed

Diff for: components/Footer.js

+17-15
Original file line numberDiff line numberDiff line change
@@ -19,21 +19,23 @@ class Footer extends Component {
1919
return (
2020
<footer className="footer flexItem-none py-3 bgDarker-1">
2121
<div className="maxW-4 mx-auto px-3 px-4@sm flex@sm flex-wrap">
22-
<ul className="listReset lineHeight-44 mb-0 flex@sm flex-wrap items-center mr-auto@sm">
23-
{ homeLink }
24-
<li className="inlineBlock mr-3">
25-
<Link to={prefixLink('/work/')}>Work</Link>
26-
</li>
27-
<li className="inlineBlock mr-3">
28-
<Link to={prefixLink('/writing/')}>Writing</Link>
29-
</li>
30-
<li className="inlineBlock mr-3">
31-
<a href={prefixLink('/resume/')}>Résumé</a>
32-
</li>
33-
<li className="inlineBlock mr-3">
34-
<Link to={prefixLink('/colophon/')}>Colophon</Link>
35-
</li>
36-
</ul>
22+
<nav className="mr-auto@sm" role="navigation">
23+
<ul className="listReset lineHeight-44 mb-0 flex@sm flex-wrap items-center">
24+
{ homeLink }
25+
<li className="inlineBlock mr-3">
26+
<Link to={prefixLink('/work/')}>Work</Link>
27+
</li>
28+
<li className="inlineBlock mr-3">
29+
<Link to={prefixLink('/writing/')}>Writing</Link>
30+
</li>
31+
<li className="inlineBlock mr-3">
32+
<a href={prefixLink('/resume/')}>Résumé</a>
33+
</li>
34+
<li className="inlineBlock mr-3">
35+
<Link to={prefixLink('/colophon/')}>Colophon</Link>
36+
</li>
37+
</ul>
38+
</nav>
3739
<ul className="listReset lineHeight-44 mb-0 flex@sm flex-wrap items-center">
3840
<li className="inlineBlock mr-3">
3941
<a href={'mailto:' + config.email}>Email</a>

Diff for: components/Header.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ class Header extends Component {
3838
}
3939

4040
return (
41-
<header className="header flexItem-none mb-4">
42-
<nav className="fs-5 maxW-4 mx-auto px-3 px-4@sm">
41+
<header className="header flexItem-none mb-4" role="banner">
42+
<nav className="fs-5 maxW-4 mx-auto px-3 px-4@sm" role="navigation">
4343
<h1 className="inline fontSize-inherit"><Link to={prefixLink('/')}>{config.siteTitle}</Link></h1>
4444
{seperator}
4545
{breadcrumbs}

Diff for: components/HeaderBlock/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class HeaderBlock extends Component {
2626
}
2727

2828
return (
29-
<header className={'cf mb-4 relative sectionBlock--' + camelCase(title)}>
29+
<header className={'cf mb-4 relative sectionBlock--' + camelCase(title)} role="banner">
3030
<div className="left@md w-25@md px-2 px-3@sm pl-0@md pr-3@md">
3131
<h1 className="h1 caps lineHeight-3 mb-1">{formattedTitle}</h1>
3232
<RhymesWith />

Diff for: components/Teaser.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class Teaser extends Component {
2121

2222
return (
2323
// TODO: Replace the flexItem-50 class with something more dynamic (quantity queries?)
24-
<article className={row ? 'flexItem-50 mb-3 mb-0@sm pr-3@sm' : 'mb-3 mb-4@sm'}>
24+
<article className={row ? 'flexItem-50 mb-3 mb-0@sm pr-3@sm' : 'mb-3 mb-4@sm'} role="article">
2525
<h3 className="h4 mb-0"><Link to={prefixLink(page.path)} className="camoLink">{title}</Link></h3>
2626
{byline}
2727
<div className="mt-2">{blurb}</div>

Diff for: pages/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class Home extends Component {
1818
<HeaderBlock title={config.siteTitle}>
1919
<div dangerouslySetInnerHTML={{ __html: config.header.text }} />
2020
</HeaderBlock>
21-
<main>
21+
<main role="main">
2222

2323
<SectionBlock
2424
title={config.work.title}

Diff for: pages/work/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class WorkIndex extends Component {
1212

1313
return (
1414
<DocumentTitle title={`${toTitleCase(route.page.file.dirname)}${config.siteTitle}`}>
15-
<main className="maxW-3 mx-auto">
15+
<main className="maxW-3 mx-auto" role="main">
1616
<h1 className="h1 mb-2">{toTitleCase(route.page.file.dirname)}</h1>
1717
<p className="fs-3 mb-4" dangerouslySetInnerHTML={{ __html: config.work.blurb }} />
1818
<Pages pages={route.pages} folder={route.page.file.dirname} />

Diff for: pages/writing/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class BlogIndex extends Component {
1313

1414
return (
1515
<DocumentTitle title={`${toTitleCase(route.page.file.dirname)}${config.siteTitle}`}>
16-
<main className="maxW-3 mx-auto">
16+
<main className="maxW-3 mx-auto" role="main">
1717
<h1 className="h1 mb-2">{toTitleCase(route.page.file.dirname)}</h1>
1818
<p className="fs-3 mb-4" dangerouslySetInnerHTML={{ __html: config.writing.blurb }} />
1919
<Pages pages={route.pages} folder={route.page.file.dirname} />

Diff for: wrappers/md.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,8 @@ class MDWrapper extends Component {
7676

7777
return (
7878
<DocumentTitle title={`${title}${config.siteTitle}`}>
79-
<main className="maxW-3 mx-auto">
80-
<article>
79+
<main className="maxW-3 mx-auto" role="main">
80+
<article role="article">
8181
<h1 className="h1 mb-0">{title}</h1>
8282
{ byline }
8383
{ intro }

0 commit comments

Comments
 (0)