kylehickinson
Follow
kylehickinson
Follow
Pinned
1,148 contributions in the last year
Contribution activity
June 2022
Created 25 commits in 3 repositories
Created a pull request in brave/brave-ios that received 2 comments
Ref #5380: Fixup push/pull transifex scripts to respect new directories
Summary of Changes
Follow up to #5380
Submitter Checklist:
Unit Tests are updated to cover new or changed functionality
User-facing strings use N…
+5
−5
•
2
comments
Opened 21 other pull requests in 2 repositories
brave/brave-ios
19
merged
- No Bug: Fix possible FaviconReader leaks in Brave Wallet
- Fix #5553: Update reader mode CSS to use correct custom fonts
- Ref #5505: Add Label override to use brave symbols and fix usages
- Ref #5380: Load sync device images correctly when making a sync chain
- Ref #5830: Add DesignSystem module and move colors/gradients/etc to it
- Ref #5380: Move shared biometrics graphic to BraveUI
- Ref #5380: Copy application shortcut icons to main bundle
- Fix #5472: Generate identical blockies as other Brave platforms
- No Bug: Pull translations from new directories
- No Bug: Fixup fastlane for enterprise + swiftlint after Sources move
- No Bug: Update fastlane version
- No Bug: Import 1.39 localizations into new directories + files
- No Bug: Fix possible crash when fetching RSS/Customized News sources
- Ref #5380: Move lower traffic targets into Sources subdirectory
- No Bug: Update some deprecated APIs and fixup swiftlint warnings
- Fix #5419: Run post-setup tasks immediately if tabs are already setup
- Ref #5380: Generate Bundle accessors instead of manually making them
- Ref #5380: Load de-amp script from correct bundle
- No Bug: Move test targets to Tests subdirectory
Reviewed 39 pull requests in 2 repositories
brave/brave-ios
25 pull requests
- Fix #5537: Wallet panel loading state
- Fix #5529: Add 1.40 translations. Fix duplicated localized string key.
- Fix #5560: Brave-Core overrides not working in debug builds
- Js/5373 de amp debounce
-
No bug: Resolve
WalletStoreleak after locking wallet - Ref #5380: Added missing sandboxed scripts from SPM Package
- Fix #5549: Update brave-core to 1.40.105 RC.
- Fix #5539: Block requests from inactive tabs
- Fix #5518 : Only inject provider for secure context
- Fix #5534: Add zero-width space for eTLD+1 url to force the origin is wrapped as a whole.
- No Bug: Bump BraveCore to 1.40.96 beta build
- Fix #5530: Update VPN support text
- Fix #5490: Refactor TransactionView to improve performance
- Fix #5260: Update VPN contact form email and add platform type to the…
- No Bug: Add more assets to vpn source target.
-
No Bug: Fix
updateTabsBarVisibility()crash. - No Bug: Add missing vpn resource to the BraveVPN target.
- No bug: Fix store not being closed after successfully made a transaction
- Fix #5458: Reset wallet preferences when resetting wallet
- Fix #5479: Set consolidation date properly.
- Fix 4437: Updated onboarding - Brave Search Callouts for Existing Users
- No Bug: Move BraveVPN to spm sources directory
- Fix #5447: Deleting tab from tab search result seems to clear the query to display full tabs
- Fix # 5450: Transaction confirmation dismissal fix
- Fix #5402: Account selection not updating to new account on some sites
- Some pull request reviews not shown.
brave/brave-core
11 pull requests
- WIP: Upgrade from Chromium 103 to Chromium 104.
- [iOS] - Added FaviconDriver for loading icons from HistoryService
- Remove dependency on the Rewards extension
- SKU SDK should be able to handle more than one environment
- [iOS] - Fixed iOS threading issues
- Add command line Brave Ads permission rule
- [iOS] - Export FavIcon fetcher and monogram view
- Implement SignAndSendTransaction, SignTransaction, and SignAllTransactions in Solana provider
- Use base::SequenceBound for Rewards database
- Upgrade from Chromium 102 to Chromium 103
- Refactor Brave Ads AdNotification to NotificationAd
Created an issue in brave/brave-ios that received 1 comment
Reader mode custom fonts (Fira/New York) not being used within the reader mode page
Description: The reader mode serif and sans-serif fonts are defaulting to helvetica/times instead of the custom fonts Actual result: Reader mode us…
1
comment
Opened 5 other issues in 2 repositories
brave/brave-ios
2
closed
1
open
brave/brave-browser
1
closed
1
open
1
contribution
in private repositories
Jun 2