kylehickinson
Follow
kylehickinson
Follow
Pinned
825 contributions in the last year
Less
More
Contribution activity
October 2021
Created 10 commits in 2 repositories
Created a pull request in brave/brave-ios that received 12 comments
Fix #4259: Replace hard-coded user facing strings with NSLocalizedString
Summary of Changes This pull request fixes #4259 Submitter Checklist: Unit Tests are updated to cover new or changed functionality User-facing s…
+1,083
−214
•
12
comments
Opened 12 other pull requests in 2 repositories
brave/brave-ios
7
merged
- Immediately focus the password field on unlock screen
- Bump BraveCore build to Beta 1.32.73
- Update Brave Wallet strings
- Add support for opening wallet URLs
- Refactor buy/send/swap actions into SwiftUI presentation context
- Fix #4279: Add support for displaying icons for token registry assets
- No Bug: Add sandbox inspector to settings debug section
brave/brave-core
1
open
4
merged
- Move iOS Brave browser state factories out of chromium_src override
- Ensure iOS builds include infura project id/key for wallet
- Repack Brave components strings with iOS builds
- Fix possible crash when notifying keying interaction before its unlocked
- Add ability to fetch Brave Wallet component file path for images/logos
Reviewed 20 pull requests in 2 repositories
brave/brave-ios
16 pull requests
- Fix: #4273 Built Send Crypto Screen
- Fix: #4371 Test network UI in Buy Screen
- Fix #4390: Remove setting window bounds.
- Ref #4272: Wallet Buy Screen enhancement
- Fix: # 4272 Buy Crypto UI. Integrated with searching, input, updates
- Fix #4259: Replace hard-coded user facing strings with NSLocalizedString
- Fix #4299: Tab tray keyboard navigation on iOS 15.
- Fix #4296: Playlist using unnecessary space when system caching
- Fix #4292: Update order of search engines in search engine picker.
- Fix #4287: Retrieve the current tab that made the request, instead of the selected tab
- Fix #4236 - Use SceneDelegate instead of AppDelegate
- Ref #4001: Update Brave Talk endpoints.
- Ref #4256: Update unit tests for the new dtoi param duration.
- Fix #4256: Update dtoi parameter duration to 30 days.
- Fix #4221: Update Search Engines.
- Ref #4277: Disable flaky testWebServerIsServingRequests test.
Created an issue in brave/brave-ios that received 2 comments
Wallet Accessibility Audit
Description: Wallet should be audited for accessibility before shipping: VoiceOver grouping, labels, values, etc. VoiceOver gestures Dynamic fo…
•
2
comments
Opened 16 other issues in 2 repositories
brave/brave-ios
7
open
4
closed
- Add ability to view URL before loading the page from the QR Code Scanner
- Disable access to swap on testnets
- Update portfolio backup banner colours
- Handle buy UI for different ethereum chains
- Add utilities to handle wei/gwei conversions for balances/fiat/etc.
- Add numbers to backup wallet phrase screens
- Add ability to add new account from within account picker in buy/send/swap
- ETH user asset is not an option if removed
- Add setting for wallet auto-lock
- Add support for adding custom ERC20 tokens
- Load proper icons for tokens/assets
brave/brave-browser
4
closed
1
open
- iOS builds do not include infura project id/keys
- iOS is missing brave component strings
- Wallet auto-lock reset on user interaction can crash if called before the users keyring is unlocked
- Add an API to obtain brave wallet's component path
- Add helper methods for handling wei conversions from hex strings
2
contributions
in private repositories
Oct 26 – Oct 27