fix: dispose readers

Author: kyleratti

ApplicationData/ApplicationData.csproj

@@ -18,6 +18,10 @@
       <PackageReference Include="Dapper.Transaction" Version="2.1.28" />
       <PackageReference Include="FruityFoundation.Base" Version="1.1.2" />
       <PackageReference Include="FruityFoundation.FsBase" Version="1.1.2" />
+      <PackageReference Include="IDisposableAnalyzers" Version="4.0.7">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
       <PackageReference Include="Microsoft.Data.Sqlite" Version="7.0.16" />
       <PackageReference Include="Microsoft.Extensions.Caching.Abstractions" Version="7.0.0" />
       <PackageReference Include="ResultMonad" Version="1.0.1" />

ApplicationData/Services/ApiKeyProvider.cs

@@ -21,7 +21,7 @@ IDbConnectionFactory dbConnectionFactory
 	public async Task<Maybe<User>> FindUserByApiKey(string apiKey)
 	{
 		using var connection = await _dbConnectionFactory.CreateReadOnlyConnection();
-		var reader = await connection.ExecuteReaderAsync(
+		using var reader = await connection.ExecuteReaderAsync(
 			@"SELECT u.user_id, u.display_username, u.developer_username, u.weight, u.created_at, u.updated_at, u.is_admin
 				FROM users u
 				INNER JOIN api_keys ak ON u.user_id = ak.user_id

ApplicationData/Services/UserProvider.cs

@@ -22,7 +22,7 @@ IDbConnectionFactory dbConnectionFactory
 	public async Task<IReadOnlyCollection<User>> GetAllUsers()
 	{
 		using var connection = await _dbConnectionFactory.CreateReadOnlyConnection();
-		var reader = await connection.ExecuteReaderAsync(
+		using var reader = await connection.ExecuteReaderAsync(
 			@"SELECT user_id, display_username, developer_username, weight, created_at, updated_at, is_deleted, is_admin
 				FROM users
 				ORDER BY created_at");
@@ -47,7 +47,7 @@ FROM users
 	public async Task<Maybe<User>> FindUserByDisplayName(string displayUsername)
 	{
 		using var connection = await _dbConnectionFactory.CreateReadOnlyConnection();
-		var reader = await connection.ExecuteReaderAsync(
+		using var reader = await connection.ExecuteReaderAsync(
 			@"SELECT user_id, display_username, developer_username, weight, created_at, updated_at, is_deleted, is_admin
 				FROM users
 				WHERE display_username LIKE @displayUsername",
@@ -71,7 +71,7 @@ FROM users
 	public async Task<Maybe<User>> FindUserByIdIncludeDeleted(int userId)
 	{
 		using var connection = await _dbConnectionFactory.CreateReadOnlyConnection();
-		var reader = await connection.ExecuteReaderAsync(
+		using var reader = await connection.ExecuteReaderAsync(
 			@"SELECT user_id, display_username, developer_username, weight, created_at, updated_at, is_deleted, is_admin
 				FROM users
 				WHERE user_id = @userId",