fix: log exceptions

Author: kyleratti

WebApi/AuthHandlers/ApiKeyAuthHandler.cs

@@ -20,26 +20,29 @@ public class ApiKeyAuthSchemeOptions : AuthenticationSchemeOptions
 
 public class ApiKeyAuthHandler : AuthenticationHandler<ApiKeyAuthSchemeOptions>
 {
+	private readonly ILogger<ApiKeyAuthHandler> _logger;
 	private readonly ApiKeyProvider _apiKeyProvider;
 	private readonly UserCache _userCache;
 	private readonly Regex _apiKeyMatch = new(@"^Key (?<key>.*)$", RegexOptions.Compiled);
 
 	/// <inheritdoc />
 	public ApiKeyAuthHandler(
+		ILogger<ApiKeyAuthHandler> logger,
 		IOptionsMonitor<ApiKeyAuthSchemeOptions> options,
-		ILoggerFactory logger,
+		ILoggerFactory loggerFactory,
 		UrlEncoder encoder,
 		ISystemClock clock,
 		ApiKeyProvider apiKeyProvider,
 		UserCache userCache
-	) : base(options, logger, encoder, clock)
+	) : base(options, loggerFactory, encoder, clock)
 	{
+		_logger = logger;
 		_apiKeyProvider = apiKeyProvider;
 		_userCache = userCache;
 	}
 
 	protected override async Task<AuthenticateResult> HandleAuthenticateAsync() =>
-		await JsonExceptionMiddleware.InvokeWithExceptionHandler(Request.HttpContext, async () =>
+		await JsonExceptionMiddleware.InvokeWithExceptionHandler(_logger, Request.HttpContext, async () =>
 		{
 			// For endpoints with IAllowAnonymous, skip the authentication check.
 			if (Context.GetEndpoint()?.Metadata.GetMetadata<IAllowAnonymous>() != null)
@@ -85,4 +88,4 @@ await Response.WriteAsJsonAsync(new
 			});
 		}
 	}
-}
+}

WebApi/Middleware/JsonExceptionMiddleware.cs

@@ -21,10 +21,15 @@ internal record CapturedException(
 
 public class JsonExceptionMiddleware
 {
+	private readonly ILogger<JsonExceptionMiddleware> _logger;
 	private readonly RequestDelegate _next;
 
-	public JsonExceptionMiddleware(RequestDelegate next)
+	public JsonExceptionMiddleware(
+		ILogger<JsonExceptionMiddleware> logger,
+		RequestDelegate next
+	)
 	{
+		_logger = logger;
 		_next = next;
 	}
 
@@ -36,25 +41,27 @@ public async Task InvokeAsync(HttpContext httpContext)
 		}
 		catch (Exception ex)
 		{
-			await HandleExceptionAsync(httpContext, ex);
+			await HandleExceptionAsync(_logger, httpContext, ex);
 		}
 	}
 
-	public static async Task<T> InvokeWithExceptionHandler<T>(HttpContext httpContext, Func<Task<T>> action)
+	public static async Task<T> InvokeWithExceptionHandler<T>(ILogger logger, HttpContext httpContext, Func<Task<T>> action)
 	{
 		try
 		{
 			return await action();
 		}
 		catch (Exception ex)
 		{
-			await HandleExceptionAsync(httpContext, ex);
+			await HandleExceptionAsync(logger, httpContext, ex);
 			throw;
 		}
 	}
 
-	private static async Task HandleExceptionAsync(HttpContext httpContext, Exception ex)
+	private static async Task HandleExceptionAsync(ILogger logger, HttpContext httpContext, Exception ex)
 	{
+		logger.LogError(ex, "An unhandled exception occurred.");
+
 		HttpStatusCode GetStatusCode()
 		{
 			if (ex.Data.Contains("HttpStatusCode") && ex.Data["HttpStatusCode"] is HttpStatusCode statusCode)
@@ -83,4 +90,4 @@ public static class JsonExceptionMiddlewareExtensions
 {
 	public static IApplicationBuilder UseJsonExceptionHandler(this IApplicationBuilder builder) =>
 		builder.UseMiddleware<JsonExceptionMiddleware>();
-}
+}