Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set connector-service token timeout to 5 min #1829

Merged
merged 5 commits into from Nov 28, 2018
Merged

Set connector-service token timeout to 5 min #1829

merged 5 commits into from Nov 28, 2018

Conversation

crabtree
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Set connector-service token timeout to 5 min

Related issue(s)

@crabtree crabtree added kind/feature Categorizes issue or PR as related to a new feature. area/application-connector Issues or PRs related to application connectivity labels Nov 27, 2018
@crabtree crabtree added this to the Sprint_Framefrog_6 milestone Nov 27, 2018
@crabtree crabtree self-assigned this Nov 27, 2018
@franpog859 franpog859 self-assigned this Nov 28, 2018
franpog859
franpog859 reviewed Nov 28, 2018
View reviewed changes
Copy link
Contributor

@franpog859 franpog859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think also the default value should be changed here.

Remember to create a PR or some issue to update documentation. I think this, this and this files should be updated.

@crabtree
Copy link
Contributor Author

@franpog859 Good catch. Updated.

@crabtree crabtree merged commit b723b5b into kyma-project:master Nov 28, 2018
@crabtree crabtree deleted the connector-service-token-timeout branch November 28, 2018 13:12
venturasr pushed a commit to venturasr/kyma that referenced this pull request Dec 11, 2018
@crabtree @santiago-ventura
Set connector-service token timeout to 5 min (kyma-project#1829)
262e24b 
* Set connector-service token timeout to 5 min
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
@dekiel
Added filters to export apiserver metrics. (kyma-project#1829)
7c53654
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekpapiernik tomekpapiernik tomekpapiernik approved these changes

@franpog859 franpog859 franpog859 approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

@janmedrek janmedrek Awaiting requested review from janmedrek

@lszymik lszymik Awaiting requested review from lszymik

@Maladie Maladie Awaiting requested review from Maladie

@Szymongib Szymongib Awaiting requested review from Szymongib

@bszwarc bszwarc Awaiting requested review from bszwarc

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

Assignees

@crabtree crabtree

@franpog859 franpog859

Labels
area/application-connector Issues or PRs related to application connectivity kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@crabtree @tomekpapiernik @franpog859