Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get active events #3765

Merged
merged 49 commits into from May 7, 2019

Conversation

@Maladie
Copy link
Contributor

commented Apr 17, 2019

Description

Changes proposed in this pull request:

  • Connector service returns URL to get names of all active events per application
  • Added endpoint in Event Service that returns all active events per application

Related issue(s)

#3342

Maladie added some commits Apr 17, 2019

crabtree and others added some commits Apr 26, 2019

Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/assets/eventsapi.yaml
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update components/event-service/internal/externalapi/healthcheckhandl…
…er_test.go

Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update components/event-service/docs/api/api.yaml
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
@Maladie

This comment has been minimized.

Copy link
Contributor Author

commented Apr 26, 2019

/retest

require.NoError(t, err)

assert.Equal(t, http.StatusOK, response.StatusCode)
assert.Equal(t, eventType, events.EventsInfo[0].Name)

This comment has been minimized.

Copy link
@Szymongib

Szymongib Apr 29, 2019

Member

I do not think you should assume that there will be only one subscription while running the test.

@@ -0,0 +1,126 @@
package subscribed

This comment has been minimized.

Copy link
@Szymongib

Szymongib Apr 29, 2019

Member

This file is not tested.

kazydek and others added some commits May 6, 2019

Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
Update docs/application-connector/docs/09-03-event-service.md
Co-Authored-By: Maladie <mariusz.szymanski@sap.com>
@kazydek

kazydek approved these changes May 6, 2019

@@ -12,6 +12,7 @@ import (
const (
MetadataURLFormat = "%s/%s/v1/metadata/services"
EventsURLFormat = "%s/%s/v1/events"
EventsInfoURLFormat = "%s/%s/v1/events/subscribed"

This comment has been minimized.

Copy link
@abbi-gaurav

abbi-gaurav May 6, 2019

Member

please consider not naming it subscribed. As discussed previously with @akgalwas, there could be scenarios where there is no Kyma Subscription but still the event needs to be consumed e.g. for data events which will be consumed by a data event processing framework.

This comment has been minimized.

Copy link
@Maladie

Maladie May 6, 2019

Author Contributor

After discussion with team and PO, we decided to stay with subscribed. It is general term in case of events, not necessarily pointing to Kyma Subscriptions.

responses:
'200':
description: 'The service is in a good health'
/{application}/v1/events/subscribed:

This comment has been minimized.

Copy link
@abbi-gaurav

abbi-gaurav May 6, 2019

Member

Same as earlier comment.

Maladie and others added some commits May 6, 2019

Explained why we want to stay with subscribed

@Maladie Maladie merged commit fedca3d into kyma-project:master May 7, 2019

100 checks passed

kyma-governance Job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Skipped.
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Job succeeded.
Details
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-configurations-generator Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Job succeeded.
Details
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-etcd-backup-job Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Job succeeded.
Details
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-installer Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Skipped.
pre-master-kyma-docs Job succeeded.
Details
pre-master-kyma-gke-central-connector Skipped.
pre-master-kyma-gke-integration Skipped.
pre-master-kyma-gke-upgrade Skipped.
pre-master-kyma-integration Skipped.
pre-master-kyma-tests-acceptance Skipped.
pre-master-kyma-tests-api-controller-acceptance-tests Skipped.
pre-master-kyma-tests-apiserver-proxy-test Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-cluster-users-test Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Skipped.
pre-master-kyma-tests-gateway-tests Job succeeded.
Details
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-ark-plugins Skipped.
pre-master-kyma-tools-docsbuilder Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-static-users-generator Skipped.
pre-rel07-kyma-common Skipped.
pre-rel07-kyma-components-api-controller Skipped.
pre-rel07-kyma-components-apiserver-proxy Skipped.
pre-rel07-kyma-components-application-broker Skipped.
pre-rel07-kyma-components-application-operator Skipped.
pre-rel07-kyma-components-application-proxy Skipped.
pre-rel07-kyma-components-application-registry Skipped.
pre-rel07-kyma-components-asset-store-controller-manager Skipped.
pre-rel07-kyma-components-binding-usage-controller Skipped.
pre-rel07-kyma-components-configurations-generator Skipped.
pre-rel07-kyma-components-connection-token-handler Skipped.
pre-rel07-kyma-components-connector-service Skipped.
pre-rel07-kyma-components-console-backend-service Skipped.
pre-rel07-kyma-components-event-bus Skipped.
pre-rel07-kyma-components-event-service Skipped.
pre-rel07-kyma-components-helm-broker Skipped.
pre-rel07-kyma-components-installer Skipped.
pre-rel07-kyma-components-istio-kyma-patch Skipped.
pre-rel07-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel07-kyma-components-kubeless-images-nodejs Skipped.
pre-rel07-kyma-components-namespace-controller Skipped.
pre-rel07-kyma-components-xip-patch Skipped.
pre-rel07-kyma-docs Skipped.
pre-rel07-kyma-tests-acceptance Skipped.
pre-rel07-kyma-tests-api-controller-acceptance-tests Skipped.
pre-rel07-kyma-tests-application-operator-tests Skipped.
pre-rel07-kyma-tests-application-registry-tests Skipped.
pre-rel07-kyma-tests-connector-service-tests Skipped.
pre-rel07-kyma-tests-console-backend-service Skipped.
pre-rel07-kyma-tests-event-bus Skipped.
pre-rel07-kyma-tests-gateway-tests Skipped.
pre-rel07-kyma-tests-knative-serving-acceptance Skipped.
pre-rel07-kyma-tests-kubeless Skipped.
pre-rel07-kyma-tests-kubeless-integration Skipped.
pre-rel07-kyma-tests-logging Skipped.
pre-rel07-kyma-tests-test-logging-monitoring Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.