Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OwnerReferences to Service for ServiceBroker #3789

Merged

Conversation

@jasiu001
Copy link
Contributor

commented Apr 18, 2019

Related to #3192 + additional scenario which creates Application, ApplicationMapping and all connected resources, removes them and check everything is cleaned up.

@polskikiel

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@jasiu001 Please fix tests and I will approve :>

@PK85
Copy link
Contributor

left a comment

Do we have a test for that scenario? If not add a test, then implement a fix.

@jasiu001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/test pre-master-kyma-tests-acceptance

@jasiu001 jasiu001 force-pushed the jasiu001:application-broker-remove-action branch from 484e574 to 86ae774 Apr 19, 2019

@jasiu001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/test pre-master-kyma-tests-acceptance

1 similar comment
@jasiu001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/test pre-master-kyma-tests-acceptance

@jasiu001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/test pre-master-kyma-components-application-broker

1 similar comment
@jasiu001

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

/test pre-master-kyma-components-application-broker

@jasiu001 jasiu001 force-pushed the jasiu001:application-broker-remove-action branch from 86ae774 to 8e7f423 Apr 19, 2019

@piotrmiskiewicz
Copy link
Contributor

left a comment

lgtm

@PK85

PK85 approved these changes Apr 23, 2019

@jasiu001 jasiu001 merged commit 426e984 into kyma-project:master Apr 23, 2019

100 checks passed

kyma-governance Skipped.
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Job succeeded.
Details
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Skipped.
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-configurations-generator Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Skipped.
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-etcd-backup-job Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Skipped.
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-installer Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Skipped.
pre-master-kyma-docs Skipped.
pre-master-kyma-gke-central-connector Skipped.
pre-master-kyma-gke-integration Skipped.
pre-master-kyma-gke-upgrade Skipped.
pre-master-kyma-integration Skipped.
pre-master-kyma-tests-acceptance Job succeeded.
Details
pre-master-kyma-tests-api-controller-acceptance-tests Skipped.
pre-master-kyma-tests-apiserver-proxy-test Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-cluster-users-test Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Skipped.
pre-master-kyma-tests-gateway-tests Skipped.
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-ark-plugins Skipped.
pre-master-kyma-tools-docsbuilder Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-static-users-generator Skipped.
pre-rel07-kyma-common Skipped.
pre-rel07-kyma-components-api-controller Skipped.
pre-rel07-kyma-components-apiserver-proxy Skipped.
pre-rel07-kyma-components-application-broker Skipped.
pre-rel07-kyma-components-application-operator Skipped.
pre-rel07-kyma-components-application-proxy Skipped.
pre-rel07-kyma-components-application-registry Skipped.
pre-rel07-kyma-components-asset-store-controller-manager Skipped.
pre-rel07-kyma-components-binding-usage-controller Skipped.
pre-rel07-kyma-components-configurations-generator Skipped.
pre-rel07-kyma-components-connection-token-handler Skipped.
pre-rel07-kyma-components-connector-service Skipped.
pre-rel07-kyma-components-console-backend-service Skipped.
pre-rel07-kyma-components-event-bus Skipped.
pre-rel07-kyma-components-event-service Skipped.
pre-rel07-kyma-components-helm-broker Skipped.
pre-rel07-kyma-components-installer Skipped.
pre-rel07-kyma-components-istio-kyma-patch Skipped.
pre-rel07-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel07-kyma-components-kubeless-images-nodejs Skipped.
pre-rel07-kyma-components-namespace-controller Skipped.
pre-rel07-kyma-components-xip-patch Skipped.
pre-rel07-kyma-docs Skipped.
pre-rel07-kyma-tests-acceptance Skipped.
pre-rel07-kyma-tests-api-controller-acceptance-tests Skipped.
pre-rel07-kyma-tests-application-operator-tests Skipped.
pre-rel07-kyma-tests-application-registry-tests Skipped.
pre-rel07-kyma-tests-connector-service-tests Skipped.
pre-rel07-kyma-tests-console-backend-service Skipped.
pre-rel07-kyma-tests-event-bus Skipped.
pre-rel07-kyma-tests-gateway-tests Skipped.
pre-rel07-kyma-tests-knative-serving-acceptance Skipped.
pre-rel07-kyma-tests-kubeless Skipped.
pre-rel07-kyma-tests-kubeless-integration Skipped.
pre-rel07-kyma-tests-logging Skipped.
pre-rel07-kyma-tests-test-logging-monitoring Skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.