Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istio rbac authorization added between ServiceCatalog and HelmBroker … #3794

Merged
merged 6 commits into from Apr 23, 2019

Conversation

@PK85
Copy link
Contributor

PK85 commented Apr 18, 2019

Description

Changes proposed in this pull request:

  • Istio rbac authorization added between ServiceCatalog and HelmBroker. Only SC could communicate with HB.

Related issue(s)
#3807

@PK85 PK85 requested a review from crabtree as a code owner Apr 19, 2019
PK85 added 3 commits Apr 19, 2019
…components and bump tests
…components and bump tests
@PK85 PK85 requested a review from kyma-project/developers as a code owner Apr 19, 2019
@PK85

This comment has been minimized.

Copy link
Contributor Author

PK85 commented Apr 19, 2019

/retest

@kyma-bot

This comment has been minimized.

Copy link
Contributor

kyma-bot commented Apr 19, 2019

@PK85: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pre-master-kyma-tests-acceptance 5b73532 link /test pre-master-kyma-tests-acceptance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@PK85 PK85 self-assigned this Apr 19, 2019
…components and bump tests
Copy link
Contributor

piotrmsc left a comment

LGTM. Communication works.

Question : is there any particular reason why helm-broker service is a nodeport?

@PK85

This comment has been minimized.

Copy link
Contributor Author

PK85 commented Apr 23, 2019

@piotrmsc, nodeport, will be fixed to clusterip in the new PR

Copy link
Member

piotrmiskiewicz left a comment

Please, create an issue about refactoring the test

@PK85 PK85 merged commit 3c5f3fe into kyma-project:master Apr 23, 2019
100 checks passed
100 checks passed
kyma-governance Skipped.
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Skipped.
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Skipped.
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-configurations-generator Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Skipped.
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-etcd-backup-job Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Skipped.
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-installer Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Job succeeded.
Details
pre-master-kyma-docs Skipped.
pre-master-kyma-gke-central-connector Job succeeded.
Details
pre-master-kyma-gke-integration Job succeeded.
Details
pre-master-kyma-gke-upgrade Job succeeded.
Details
pre-master-kyma-integration Job succeeded.
Details
pre-master-kyma-tests-acceptance Skipped.
pre-master-kyma-tests-api-controller-acceptance-tests Skipped.
pre-master-kyma-tests-apiserver-proxy-test Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-cluster-users-test Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Skipped.
pre-master-kyma-tests-gateway-tests Skipped.
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-ark-plugins Skipped.
pre-master-kyma-tools-docsbuilder Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-static-users-generator Skipped.
pre-rel07-kyma-common Skipped.
pre-rel07-kyma-components-api-controller Skipped.
pre-rel07-kyma-components-apiserver-proxy Skipped.
pre-rel07-kyma-components-application-broker Skipped.
pre-rel07-kyma-components-application-operator Skipped.
pre-rel07-kyma-components-application-proxy Skipped.
pre-rel07-kyma-components-application-registry Skipped.
pre-rel07-kyma-components-asset-store-controller-manager Skipped.
pre-rel07-kyma-components-binding-usage-controller Skipped.
pre-rel07-kyma-components-configurations-generator Skipped.
pre-rel07-kyma-components-connection-token-handler Skipped.
pre-rel07-kyma-components-connector-service Skipped.
pre-rel07-kyma-components-console-backend-service Skipped.
pre-rel07-kyma-components-event-bus Skipped.
pre-rel07-kyma-components-event-service Skipped.
pre-rel07-kyma-components-helm-broker Skipped.
pre-rel07-kyma-components-installer Skipped.
pre-rel07-kyma-components-istio-kyma-patch Skipped.
pre-rel07-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel07-kyma-components-kubeless-images-nodejs Skipped.
pre-rel07-kyma-components-namespace-controller Skipped.
pre-rel07-kyma-components-xip-patch Skipped.
pre-rel07-kyma-docs Skipped.
pre-rel07-kyma-tests-acceptance Skipped.
pre-rel07-kyma-tests-api-controller-acceptance-tests Skipped.
pre-rel07-kyma-tests-application-operator-tests Skipped.
pre-rel07-kyma-tests-application-registry-tests Skipped.
pre-rel07-kyma-tests-connector-service-tests Skipped.
pre-rel07-kyma-tests-console-backend-service Skipped.
pre-rel07-kyma-tests-event-bus Skipped.
pre-rel07-kyma-tests-gateway-tests Skipped.
pre-rel07-kyma-tests-knative-serving-acceptance Skipped.
pre-rel07-kyma-tests-kubeless Skipped.
pre-rel07-kyma-tests-kubeless-integration Skipped.
pre-rel07-kyma-tests-logging Skipped.
pre-rel07-kyma-tests-test-logging-monitoring Skipped.
@PK85 PK85 deleted the PK85:istio-rbac-brokers branch Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.