Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Broker with one service #3939

Conversation

@piotrmiskiewicz
Copy link
Contributor

commented May 7, 2019

Description

Changes proposed in this pull request:

  • Application Broker has only one k8s Service
  • all namespaced ServiceBroker instances are configured to the same Service with basepath as namespace

Related: #3814

@piotrmiskiewicz

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

/test pre-master-kyma-components-application-broker

@piotrmiskiewicz piotrmiskiewicz force-pushed the piotrmiskiewicz:application-broker-with-one-k8s-service branch 2 times, most recently from 31c4fc7 to 3e52757 May 10, 2019

@piotrmiskiewicz piotrmiskiewicz removed the WIP label May 10, 2019

@piotrmiskiewicz piotrmiskiewicz marked this pull request as ready for review May 10, 2019

@piotrmiskiewicz piotrmiskiewicz force-pushed the piotrmiskiewicz:application-broker-with-one-k8s-service branch from 3e52757 to cbed107 May 10, 2019

@kyma-bot

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

@piotrmiskiewicz: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pre-master-kyma-integration 31c4fc7 link /test pre-master-kyma-integration
pre-master-kyma-gke-central-connector 31c4fc7 link /test pre-master-kyma-gke-central-connector
pre-master-kyma-gke-integration 31c4fc7 link /test pre-master-kyma-gke-integration
pre-master-kyma-gke-upgrade 31c4fc7 link /test pre-master-kyma-gke-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@piotrmiskiewicz piotrmiskiewicz force-pushed the piotrmiskiewicz:application-broker-with-one-k8s-service branch 2 times, most recently from 3ae6612 to 1e73b8d May 10, 2019

Show resolved Hide resolved components/application-broker/README.md Outdated
Show resolved Hide resolved components/application-broker/internal/nsbroker/facade.go Outdated
Show resolved Hide resolved components/application-broker/internal/nsbroker/facade.go Outdated
Show resolved Hide resolved components/application-broker/internal/nsbroker/facade.go Outdated

// legacyFacade is responsible for creation k8s objects for namespaced broker
// like it was done in production code before a switch to one k8s service for the application broker.
// The implementation is a copy of old Facade with removed unnecessary code (broker sync, logging)

This comment has been minimized.

Copy link
@polskikiel

polskikiel May 10, 2019

Contributor

Please add a comment that it's used only in tests

This comment has been minimized.

Copy link
@piotrmiskiewicz

piotrmiskiewicz May 10, 2019

Author Contributor

added comment

return errors.Wrapf(err, "while getting service name from URL in namespace %s", broker.Namespace)
}

if broker.Spec.URL == expectedURL {

This comment has been minimized.

Copy link
@polskikiel

polskikiel May 10, 2019

Contributor

please remove doubled check

This comment has been minimized.

Copy link
@piotrmiskiewicz

piotrmiskiewicz May 10, 2019

Author Contributor

removed

@piotrmiskiewicz piotrmiskiewicz force-pushed the piotrmiskiewicz:application-broker-with-one-k8s-service branch 2 times, most recently from b6582cf to 0c5b2c3 May 10, 2019

@piotrmiskiewicz piotrmiskiewicz force-pushed the piotrmiskiewicz:application-broker-with-one-k8s-service branch from f06417f to 7cbb3a9 May 10, 2019

@piotrmiskiewicz piotrmiskiewicz merged commit e9e5bd3 into kyma-project:master May 10, 2019

100 checks passed

kyma-governance Job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Job succeeded.
Details
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Skipped.
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-configurations-generator Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Skipped.
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-etcd-backup-job Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Skipped.
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-installer Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Skipped.
pre-master-kyma-gke-central-connector Skipped.
pre-master-kyma-gke-integration Skipped.
pre-master-kyma-gke-upgrade Skipped.
pre-master-kyma-integration Skipped.
pre-master-kyma-tests-acceptance Skipped.
pre-master-kyma-tests-api-controller-acceptance-tests Skipped.
pre-master-kyma-tests-apiserver-proxy-test Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-cluster-users-test Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Skipped.
pre-master-kyma-tests-gateway-tests Skipped.
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-ark-plugins Skipped.
pre-master-kyma-tools-docsbuilder Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-static-users-generator Skipped.
pre-rel09-kyma-common Skipped.
pre-rel09-kyma-components-api-controller Skipped.
pre-rel09-kyma-components-apiserver-proxy Skipped.
pre-rel09-kyma-components-application-broker Skipped.
pre-rel09-kyma-components-application-gateway Skipped.
pre-rel09-kyma-components-application-operator Skipped.
pre-rel09-kyma-components-application-registry Skipped.
pre-rel09-kyma-components-asset-metadata-service Skipped.
pre-rel09-kyma-components-asset-store-controller-manager Skipped.
pre-rel09-kyma-components-asset-upload-service Skipped.
pre-rel09-kyma-components-binding-usage-controller Skipped.
pre-rel09-kyma-components-cms-controller-manager Skipped.
pre-rel09-kyma-components-configurations-generator Skipped.
pre-rel09-kyma-components-connection-token-handler Skipped.
pre-rel09-kyma-components-connectivity-certs-controller Skipped.
pre-rel09-kyma-components-connector-service Skipped.
pre-rel09-kyma-components-console-backend-service Skipped.
pre-rel09-kyma-components-event-bus Skipped.
pre-rel09-kyma-components-event-service Skipped.
pre-rel09-kyma-components-helm-broker Skipped.
pre-rel09-kyma-components-installer Skipped.
pre-rel09-kyma-components-istio-kyma-patch Skipped.
pre-rel09-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel09-kyma-components-kubeless-images-nodejs Skipped.
pre-rel09-kyma-components-namespace-controller Skipped.
pre-rel09-kyma-components-xip-patch Skipped.
pre-rel09-kyma-tests-acceptance Skipped.
pre-rel09-kyma-tests-api-controller-acceptance-tests Skipped.
pre-rel09-kyma-tests-apiserver-proxy-test Skipped.
pre-rel09-kyma-tests-application-gateway-tests Skipped.
pre-rel09-kyma-tests-application-operator-tests Skipped.
pre-rel09-kyma-tests-application-registry-tests Skipped.
pre-rel09-kyma-tests-asset-store Skipped.
pre-rel09-kyma-tests-cluster-users-test Skipped.
pre-rel09-kyma-tests-connection-token-handler-tests Skipped.
pre-rel09-kyma-tests-connector-service-tests Skipped.
pre-rel09-kyma-tests-console-backend-service Skipped.

Szymongib added a commit to Szymongib/kyma that referenced this pull request May 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.