Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api-controller bump & api-controller-acceptance-tests bump #4490

Merged
merged 6 commits into from Jun 17, 2019

Conversation

@strekm
Copy link
Contributor

strekm commented Jun 11, 2019

Description

Changes proposed in this pull request:

  • api-controller bump

Related issue(s)
see #2694

@strekm strekm added this to the Sprint_Goat_14 milestone Jun 11, 2019
@strekm strekm requested a review from kyma-project/developers as a code owner Jun 11, 2019
@strekm

This comment has been minimized.

Copy link
Contributor Author

strekm commented Jun 11, 2019

/retest

1 similar comment
@strekm

This comment has been minimized.

Copy link
Contributor Author

strekm commented Jun 12, 2019

/retest

@strekm strekm changed the title api-controller bump api-controller bump & api-controller-acceptance-tests bump Jun 12, 2019
@kubadz

This comment has been minimized.

Copy link
Contributor

kubadz commented Jun 12, 2019

/test pre-master-kyma-gke-upgrade

@kubadz

This comment has been minimized.

Copy link
Contributor

kubadz commented Jun 12, 2019

I tested this manually with some additional cases not covered in tests, and everything works fine.

I would give an approve but I have one question:
are you planning to set blacklisted service mentioned in issue (kubernetes.default) in a proper ENV in api-controller deployment as a part of this PR, or you will create another PR with that change?

@kubadz
kubadz approved these changes Jun 13, 2019
resources/core/charts/api-controller/values.yaml Outdated Show resolved Hide resolved
@strekm strekm merged commit fd5223c into kyma-project:master Jun 17, 2019
100 checks passed
100 checks passed
kyma-governance Skipped.
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Skipped.
pre-master-kyma-components-application-connectivity-validator Skipped.
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Skipped.
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-configurations-generator Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Skipped.
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-etcd-backup-job Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Skipped.
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-installer Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Job succeeded.
Details
pre-master-kyma-gke-central-connector Skipped.
pre-master-kyma-gke-integration Job succeeded.
Details
pre-master-kyma-gke-minio-gateway Skipped.
pre-master-kyma-gke-upgrade Job succeeded.
Details
pre-master-kyma-integration Job succeeded.
Details
pre-master-kyma-tests-acceptance Skipped.
pre-master-kyma-tests-api-controller-acceptance-tests Skipped.
pre-master-kyma-tests-apiserver-proxy-test Skipped.
pre-master-kyma-tests-application-connector-tests Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-cluster-users-test Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Skipped.
pre-master-kyma-tests-gateway-tests Skipped.
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-static-users-generator Skipped.
pre-master-kyma-tools-velero-plugins Skipped.
pre-rel10-kyma-common Skipped.
pre-rel10-kyma-components-api-controller Skipped.
pre-rel10-kyma-components-apiserver-proxy Skipped.
pre-rel10-kyma-components-application-broker Skipped.
pre-rel10-kyma-components-application-gateway Skipped.
pre-rel10-kyma-components-application-operator Skipped.
pre-rel10-kyma-components-application-registry Skipped.
pre-rel10-kyma-components-asset-metadata-service Skipped.
pre-rel10-kyma-components-asset-store-controller-manager Skipped.
pre-rel10-kyma-components-asset-upload-service Skipped.
pre-rel10-kyma-components-binding-usage-controller Skipped.
pre-rel10-kyma-components-cms-controller-manager Skipped.
pre-rel10-kyma-components-configurations-generator Skipped.
pre-rel10-kyma-components-connection-token-handler Skipped.
pre-rel10-kyma-components-connectivity-certs-controller Skipped.
pre-rel10-kyma-components-connector-service Skipped.
pre-rel10-kyma-components-console-backend-service Skipped.
pre-rel10-kyma-components-event-bus Skipped.
pre-rel10-kyma-components-event-service Skipped.
pre-rel10-kyma-components-helm-broker Skipped.
pre-rel10-kyma-components-installer Skipped.
pre-rel10-kyma-components-istio-kyma-patch Skipped.
pre-rel10-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel10-kyma-components-kubeless-images-nodejs Skipped.
pre-rel10-kyma-components-namespace-controller Skipped.
pre-rel10-kyma-components-xip-patch Skipped.
pre-rel10-kyma-tests-acceptance Skipped.
pre-rel10-kyma-tests-api-controller-acceptance-tests Skipped.
pre-rel10-kyma-tests-apiserver-proxy-test Skipped.
pre-rel10-kyma-tests-application-gateway-tests Skipped.
pre-rel10-kyma-tests-application-operator-tests Skipped.
pre-rel10-kyma-tests-application-registry-tests Skipped.
pre-rel10-kyma-tests-asset-store Skipped.
pre-rel10-kyma-tests-cluster-users-test Skipped.
pre-rel10-kyma-tests-connection-token-handler-tests Skipped.
@strekm strekm deleted the strekm:api-controller-image-bump branch Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.