Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor e2e-tester.go for event-bus #4860

Merged
merged 17 commits into from Jul 11, 2019

Conversation

@anishj0shi
Copy link
Member

anishj0shi commented Jul 10, 2019

w.ref.t. #4265

  1. Structify global variables and use their instances in relevant functions
  2. Table Driven Checks within checkSubscriberReceivedEventHeaders in lieu of Cascading Conditional statements
Copy link
Contributor

nachtmaar left a comment

Refactoring looks good for me. Left some optional ideas as review comments.

tests/event-bus/e2e-tester/e2e-tester.go Show resolved Hide resolved
tests/event-bus/e2e-tester/e2e-tester.go Outdated Show resolved Hide resolved
tests/event-bus/e2e-tester/e2e-tester.go Show resolved Hide resolved
tests/event-bus/e2e-tester/e2e-tester.go Outdated Show resolved Hide resolved
tests/event-bus/e2e-tester/e2e-tester.go Show resolved Hide resolved
anishj0shi added 2 commits Jul 10, 2019
@anishj0shi anishj0shi requested a review from nachtmaar Jul 10, 2019
anishj0shi added 2 commits Jul 11, 2019
@anishj0shi anishj0shi merged commit d72e2c1 into kyma-project:master Jul 11, 2019
100 checks passed
100 checks passed
kyma-governance Skipped.
license/cla Contributor License Agreement is signed.
Details
pre-master-kyma-backup-test Skipped.
pre-master-kyma-common Skipped.
pre-master-kyma-components-api-controller Skipped.
pre-master-kyma-components-apiserver-proxy Skipped.
pre-master-kyma-components-application-broker Skipped.
pre-master-kyma-components-application-connectivity-certs-setup-job Skipped.
pre-master-kyma-components-application-connectivity-validator Skipped.
pre-master-kyma-components-application-gateway Skipped.
pre-master-kyma-components-application-operator Skipped.
pre-master-kyma-components-application-registry Skipped.
pre-master-kyma-components-asset-metadata-service Skipped.
pre-master-kyma-components-asset-store-controller-manager Skipped.
pre-master-kyma-components-asset-upload-service Skipped.
pre-master-kyma-components-cms-controller-manager Skipped.
pre-master-kyma-components-connection-token-handler Skipped.
pre-master-kyma-components-connectivity-certs-controller Skipped.
pre-master-kyma-components-connector-service Skipped.
pre-master-kyma-components-console-backend-service Skipped.
pre-master-kyma-components-dex-static-user-configurer Skipped.
pre-master-kyma-components-etcd-tls-setup-job Skipped.
pre-master-kyma-components-event-bus Skipped.
pre-master-kyma-components-event-service Skipped.
pre-master-kyma-components-helm-broker Skipped.
pre-master-kyma-components-iam-kubeconfig-service Skipped.
pre-master-kyma-components-istio-kyma-patch Skipped.
pre-master-kyma-components-k8s-dashboard-proxy Skipped.
pre-master-kyma-components-kubeless-images-nodejs Skipped.
pre-master-kyma-components-kyma-operator Skipped.
pre-master-kyma-components-namespace-controller Skipped.
pre-master-kyma-components-service-binding-usage-controller Skipped.
pre-master-kyma-components-xip-patch Skipped.
pre-master-kyma-development-artifacts Skipped.
pre-master-kyma-gke-central-connector Skipped.
pre-master-kyma-gke-integration Skipped.
pre-master-kyma-gke-minio-gateway Skipped.
pre-master-kyma-gke-minio-gateway-migration Skipped.
pre-master-kyma-gke-upgrade Skipped.
pre-master-kyma-integration Skipped.
pre-master-kyma-tests-acceptance Skipped.
pre-master-kyma-tests-application-connector-tests Skipped.
pre-master-kyma-tests-application-gateway-tests Skipped.
pre-master-kyma-tests-application-operator-tests Skipped.
pre-master-kyma-tests-application-registry-tests Skipped.
pre-master-kyma-tests-asset-store Skipped.
pre-master-kyma-tests-connection-token-handler-tests Skipped.
pre-master-kyma-tests-connector-service-tests Skipped.
pre-master-kyma-tests-console-backend-service Skipped.
pre-master-kyma-tests-end-to-end-backup-restore-test Skipped.
pre-master-kyma-tests-end-to-end-kubeless-integration Skipped.
pre-master-kyma-tests-end-to-end-upgrade Skipped.
pre-master-kyma-tests-event-bus Job succeeded.
Details
pre-master-kyma-tests-integration-api-controller Skipped.
pre-master-kyma-tests-integration-apiserver-proxy Skipped.
pre-master-kyma-tests-integration-cluster-users Skipped.
pre-master-kyma-tests-integration-dex Skipped.
pre-master-kyma-tests-integration-event-service Skipped.
pre-master-kyma-tests-integration-gateway Skipped.
pre-master-kyma-tests-integration-logging Skipped.
pre-master-kyma-tests-integration-monitoring Skipped.
pre-master-kyma-tests-knative-serving Skipped.
pre-master-kyma-tests-kubeless Skipped.
pre-master-kyma-tests-logging Skipped.
pre-master-kyma-tests-monitoring Skipped.
pre-master-kyma-tests-test-namespace-controller Skipped.
pre-master-kyma-tools-alpine-net Skipped.
pre-master-kyma-tools-failery Skipped.
pre-master-kyma-tools-gcp-broker-provider Skipped.
pre-master-kyma-tools-load-test Skipped.
pre-master-kyma-tools-velero-plugins Skipped.
pre-rel11-kyma-common Skipped.
pre-rel11-kyma-components-api-controller Skipped.
pre-rel11-kyma-components-apiserver-proxy Skipped.
pre-rel11-kyma-components-application-broker Skipped.
pre-rel11-kyma-components-application-gateway Skipped.
pre-rel11-kyma-components-application-operator Skipped.
pre-rel11-kyma-components-application-registry Skipped.
pre-rel11-kyma-components-asset-metadata-service Skipped.
pre-rel11-kyma-components-asset-store-controller-manager Skipped.
pre-rel11-kyma-components-asset-upload-service Skipped.
pre-rel11-kyma-components-binding-usage-controller Skipped.
pre-rel11-kyma-components-cms-controller-manager Skipped.
pre-rel11-kyma-components-connection-token-handler Skipped.
pre-rel11-kyma-components-connectivity-certs-controller Skipped.
pre-rel11-kyma-components-connector-service Skipped.
pre-rel11-kyma-components-console-backend-service Skipped.
pre-rel11-kyma-components-dex-static-user-configurer Skipped.
pre-rel11-kyma-components-event-bus Skipped.
pre-rel11-kyma-components-event-service Skipped.
pre-rel11-kyma-components-helm-broker Skipped.
pre-rel11-kyma-components-iam-kubeconfig-service Skipped.
pre-rel11-kyma-components-istio-kyma-patch Skipped.
pre-rel11-kyma-components-k8s-dashboard-proxy Skipped.
pre-rel11-kyma-components-kubeless-images-nodejs Skipped.
pre-rel11-kyma-components-namespace-controller Skipped.
pre-rel11-kyma-components-xip-patch Skipped.
pre-rel11-kyma-tests-acceptance Skipped.
pre-rel11-kyma-tests-application-gateway-tests Skipped.
pre-rel11-kyma-tests-application-operator-tests Skipped.
@anishj0shi anishj0shi deleted the anishj0shi:refactor-e2etests branch Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.