Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use newest buildpack in Makefiles and newest images in Dockerfiles of Application Connectivity #6244

Merged
merged 14 commits into from Nov 19, 2019
Merged

Use newest buildpack in Makefiles and newest images in Dockerfiles of Application Connectivity #6244

merged 14 commits into from Nov 19, 2019

Conversation

franpog859
Copy link
Contributor

@franpog859 franpog859 commented Nov 8, 2019

Description

Changes proposed in this pull request:

  • Use newest buildpack in Makefiles of Application Connectivity
  • Use newest images in Dockerfiles of Application Connectivity
  • Add licenses to .gitignores
  • Adjust old development scripts to match new Makefile approach

Related issue(s)

See the issue #6113

@franpog859 franpog859 added WIP area/application-connector Issues or PRs related to application connectivity labels Nov 8, 2019
@franpog859 franpog859 added this to the Sprint_Framefrog_19 milestone Nov 8, 2019
@franpog859 franpog859 changed the title Use newest buildpack in Makefiles and newest golang images in Dockerfiles of Application Connectivity Use newest buildpack in Makefiles and newest images in Dockerfiles of Application Connectivity Nov 8, 2019
@franpog859 franpog859 removed the WIP label Nov 8, 2019
@netlify
Copy link

netlify bot commented Nov 14, 2019

🥰 Documentation preview ready! 🥰

Built with commit d818c82

https://deploy-preview-6244--kyma-project-docs-preview.netlify.com

Copy link
Contributor

@Szymongib Szymongib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump images of components ;)

components/application-registry/scripts/can-i-commit.sh Outdated Show resolved Hide resolved
components/connector-service/scripts/can-i-commit.sh Outdated Show resolved Hide resolved
tests/application-connector-tests/Dockerfile Outdated Show resolved Hide resolved
@franpog859 franpog859 requested a review from a team as a code owner November 15, 2019 13:54
@franpog859 franpog859 merged commit fbf1000 into kyma-project:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants