Support the gitops reference in the function-controller #9134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pPrecel
requested review from
aerfio,
anishj0shi,
k15r,
lilitgh,
m00g3n,
magicmatatjahu,
marcobebway,
montaro and
nachtmaar
as code owners
|
💩 Documentation preview fail... 💩 Built with commit 8980d27 https://app.netlify.com/sites/kyma-project-docs-preview/deploys/5f2d30ebe56e0100082f1f43 |
pPrecel
requested review from
akucharska,
dariadomagala-sap,
kwiatekus,
parostatkiem-zz and
Wawrzyn321
as code owners
pPrecel
force-pushed
the
reference-git-function
branch
from
16c9071
to
31c3112
Compare
pPrecel
requested review from
alexandra-simeonova,
bszwarc,
janmedrek,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj,
piotrmsc,
PK85 and
tomekpapiernik
as code owners
|
/retest |
|
/retest |
pPrecel
force-pushed
the
reference-git-function
branch
from
9755e94
to
d2e784d
Compare
tgorgol
reviewed
Aug 7, 2020
components/function-controller/internal/controllers/serverless/function_controller.go
Show resolved
Hide resolved
components/function-controller/internal/controllers/serverless/function_controller.go
Outdated
Show resolved
Hide resolved
|
Tag support turned out to be a bit more tricky than we expected. For now we'll support only commit hash and branch as a reference. |
|
@pPrecel: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
tgorgol
force-pushed
the
reference-git-function
branch
from
775a600
to
8980d27
Compare
m00g3n
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Issue #8959