Conversation
danedane-haider
commented
May 20, 2022
danedane-haider
commented
- Changed "Plot filters" to "Plot Frequency response of filters"
- Added Plot for time-domain representation
|
looks good to me. good additions. I will test that it works. |
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Thanks for putting this together! The main thing here is to maintain the original style of the script. Unfortunately, the latest PR (#673) destroyed the script, so you may want to look at the commit just before that PR was merged (31630ca). The goal is to have your changes be as small as possible with respect to that version.
|
@danedane-haider Do you have the bandwidth to make the necessary changes? |
Edits as required: - original formatting - line width reduction - psi <- psi_i
|
Hey there,
Thanks for the kind reminder, this somehow slipped through, sry. I did the changes as requested and committed, hope this worked out :)
Cheers,
Dani
… Am 14.06.2022 um 03:01 schrieb Muawiz Sajjad Chaudhary ***@***.***>:
@danedane-haider <https://github.com/danedane-haider> Do you have the bandwidth to make the necessary changes?
—
Reply to this email directly, view it on GitHub <#815 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANJ7SPCBVGZRXYSZEDPNJ7DVO7KXLANCNFSM5WP22LTQ>.
You are receiving this because you were mentioned.
|
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
@danedane-haider One final round of edits (from my side at least) and I'm good with merging. Great job!
in light of kymatio#854 and kymatio#882 enable TeX rendering
|
I have rebased and updated the comments. @danedane-haider thanks again |
Codecov Report
@@ Coverage Diff @@
## dev #815 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 64 64
Lines 2257 2257
=======================================
Hits 1985 1985
Misses 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
janden
left a comment
janden
left a comment
There was a problem hiding this comment.
Looks good. Thanks again!
|
@MuawizChaudhary once you approve this, we can merge |
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
Great work @danedane-haider @lostanlen
by Daniel Haider and Vincent Lostanlen approved by Muawiz Chaudhary and Joakim Andén * Update plot_filters.py * Update plot_filters.py * Update plot_filters.py Edits as required: - original formatting - line width reduction - psi <- psi_i * Update plot_filters.py * update examples/1d/plot_filters in light of #854 and #882 enable TeX rendering Co-authored-by: Vincent Lostanlen <vincent.lostanlen@ls2n.fr>
6 participants
