-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC Output shape documentation #820
DOC Output shape documentation #820
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #820 +/- ##
=======================================
Coverage 88.03% 88.03%
=======================================
Files 64 64
Lines 2323 2323
=======================================
Hits 2045 2045
Misses 278 278
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
how can a doc change cause |
@lostanlen this test has been failing for python 3.7, pytorch 1.8, but its a tensorflow test??? so I dont get it. @janden got any hints? Edit: seems related to #663 |
@janden @edouardoyallon have bandwidth to review? |
I add some words stating that the output shape is dependent on the max order. I also fix the given calculation of output shape for 3d.
Fixes Issue #454 and #639