Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC Output shape documentation #820

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

MuawizChaudhary
Copy link
Collaborator

@MuawizChaudhary MuawizChaudhary commented May 30, 2022

I add some words stating that the output shape is dependent on the max order. I also fix the given calculation of output shape for 3d.

Fixes Issue #454 and #639

@MuawizChaudhary MuawizChaudhary added good first issue Good for newcomers 1D Issue with 1D scattering code 2D Issue with 2D scattering code 3D Issue with 3D scattering code labels May 30, 2022
@MuawizChaudhary MuawizChaudhary added this to the 0.3.alpha milestone May 30, 2022
@MuawizChaudhary MuawizChaudhary self-assigned this May 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.03%. Comparing base (ca9073f) to head (83116f8).
Report is 40 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #820   +/-   ##
=======================================
  Coverage   88.03%   88.03%           
=======================================
  Files          64       64           
  Lines        2323     2323           
=======================================
  Hits         2045     2045           
  Misses        278      278           
Flag Coverage Δ
jenkins_main 88.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lostanlen
Copy link
Collaborator

how can a doc change cause FAILED tests/scattering2d/test_tensorflow_backend_2d.py::TestFFT::test_fft[TensorFlowBackend2D] ?

@MuawizChaudhary
Copy link
Collaborator Author

MuawizChaudhary commented May 30, 2022

how can a doc change cause FAILED tests/scattering2d/test_tensorflow_backend_2d.py::TestFFT::test_fft[TensorFlowBackend2D] ?

@lostanlen this test has been failing for python 3.7, pytorch 1.8, but its a tensorflow test??? so I dont get it. @janden got any hints?

Edit: seems related to #663

@MuawizChaudhary MuawizChaudhary changed the title [DOC] Output shape documentation DOC Output shape documentation May 31, 2022
@MuawizChaudhary
Copy link
Collaborator Author

@janden @edouardoyallon have bandwidth to review?

@janden janden merged commit 8e1327c into kymatio:dev Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1D Issue with 1D scattering code 2D Issue with 2D scattering code 3D Issue with 3D scattering code good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants